Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-8611]- New DatePicker Component #11151
feat: [M3-8611]- New DatePicker Component #11151
Changes from 81 commits
b274baf
f958dab
5d0a476
93aab07
d7deb4f
a550f05
de0f63e
426c42c
3fb49a6
6c76508
1653a6b
00421cf
959730a
d9bd490
960415e
b9f4745
b0b9264
6c70559
96eb34d
74b1635
70d1422
342fd96
bfed239
8a19f9b
9e9c14f
a25728e
3196f2a
4794d04
e977a94
add3f10
2fafd33
b3463ae
a325e30
b1e2a51
1b0931b
9b2de1d
ff89c50
4dbe28d
b2b7d97
04514de
e343821
7fd4fa5
81ec4f8
4e25a94
52a7276
423f4b7
34f03e3
f87fbce
f47f919
2578b83
43810e7
fa7bd52
3b6f981
9b10623
9d32d3d
11d8780
862134f
2643bd6
7aec8c9
0c379a2
73e0a20
194b0d2
0ffaade
b2d591f
efcfe5c
2ca7adf
31dc03e
cd875be
5f35d70
208b2a0
d1c3fa1
6186d26
2cd8366
b8f2d73
51b1a29
e523043
f0dd5c0
9abec60
fa3e186
1ab71f9
ee326f1
18d4483
dc5291f
8e3c8c1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test for typing the date in the input?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I tried to cover this test but faced an issue because the TextField component currently allows free-form typing. Addressing this would require updating our TextField component to support a date type field or exploring alternative approaches to handle date-specific input more effectively. This also, involves in restricting free from typing on the input field. I will create a separate ticket to tackle this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like stuff that belongs in the MUI theme. Can we move styles like this into
light.ts
? Seems like this might helpThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Moving these to foundations/themes/light.ts is not reflecting in the Storybook component but is working in the CM app. I will address this in the following PR for the DateRange Picker - M3-8990.