Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-8849] - Include migration type in Linode status when it is migrating #11295

Closed

Conversation

harsh-akamai
Copy link
Contributor

@harsh-akamai harsh-akamai commented Nov 20, 2024

Description 📝

The time when the Linode is being cold migrated, currently we are showing it along with status as "Migrating (10%)". we are not showing type. When Linode is in the Warm Migration, we are showing it in the notifications but nothing is reflected in the Linode status.

Changes 🔄

  • When Linode is migrating, Linode status will reflect that along with the Migration type.
    • For Warm Migrations, it should be show WARM MIGRATING (80%)
    • For Cold Migrations, it should be show COLD MIGRATING (80%)

Preview 📷

Include a screenshot or screen recording of the change.

Before After
10_31_56 10_32_33 10_34_08

How to test 🧪

Reproduction steps

  • Check the internal ticket for details

Verification steps

  • Verify that 'COLD MIGRATING(56%)' or 'WARM MIGRATING(56%)' text is seen in the Linode Detail header

As an Author, I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@harsh-akamai harsh-akamai self-assigned this Nov 20, 2024
@harsh-akamai harsh-akamai marked this pull request as ready for review November 28, 2024 07:00
@harsh-akamai harsh-akamai requested a review from a team as a code owner November 28, 2024 07:00
@harsh-akamai harsh-akamai requested review from abailly-akamai and pmakode-akamai and removed request for a team November 28, 2024 07:00
@harsh-akamai harsh-akamai reopened this Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

Coverage Report:
Base Coverage: 86.84%
Current Coverage: 86.84%

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing 👍

I wonder if we should also update the Event Notification messages: https://github.com/linode/manager/blob/develop/packages/manager/src/features/Events/factories/linode.tsx#L247-L298

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing465 Passing2 Skipped99m 44s

Details

Failing Tests
SpecTest
smoke-billing-activity.spec.tsBilling Activity Feed » displays correct timezone for invoice and payment dates

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/billing/smoke-billing-activity.spec.ts"

Copy link

github-actions bot commented Jan 4, 2025

This PR is stale because it has been open 15 days with no activity. Please attend to this PR or it will be closed in 5 days

@github-actions github-actions bot added the Stale label Jan 4, 2025
@github-actions github-actions bot closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants