refactor: [M3-8653] - Migrate Toggle component to linode/ui package
#11296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coliu-akamai
changed the title
Toggle component to linode/ui packageToggle component to linode/ui package
coliu-akamai
changed the title
Toggle component to linode/ui packageToggle component to linode/ui package
coliu-akamai
requested review from
carrillo-erik and
cpathipa
and removed request for
a team
|
Coverage Report: ❌ |
coliu-akamai
commented
Nov 21, 2024
| @@ -1,11 +1,10 @@ | |||
| import '@testing-library/jest-dom/vitest'; | |||
There was a problem hiding this comment.
for any ui package file changes that aren't the ToggleOn/ToggleOff icons or the Toggle component, these are just eslint/prettier changes that I did while fixing some merge conflicts
jaalah-akamai
approved these changes
Nov 26, 2024
coliu-akamai
added
Add'tl Approval Needed
pmakode-akamai
approved these changes
Nov 26, 2024
coliu-akamai
added
Approved
Cloud Manager UI test results🎉 455 passing tests on test run #7 ↗︎
|
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 30m 49s |
| Commit |
|
| Committer | Connie Liu |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
5
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
455
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Migrate
Togglecomponent tolinode/uipackage.Changes 🔄
Togglecomponent tolinode/uipackageToggleOffandToggleOnicon tolinode/uipackageTarget release date 🗓️
12/10/24
How to test 🧪
Verification steps
Togglestory in Storybook should be in good shapeAs an Author, I have considered 🤔
As an Author, before moving this PR from Draft to Open, I confirmed ✅