upcoming: [DI-21842] - Fixed recharts issues in Cloudpulse #11317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhagra-akamai
requested review from
carrillo-erik and
cpathipa
and removed request for
a team
venkymano-akamai
approved these changes
Nov 25, 2024
|
Coverage Report: ❌ |
bnussman-akamai
approved these changes
Nov 25, 2024
nikhagra-akamai
commented
Nov 25, 2024
Comment on lines
120
to
122
| [theme.breakpoints.up(1100)]: { | ||
| height: legendHeight, | ||
| }, |
There was a problem hiding this comment.
@jaalah-akamai I've removed this breakpoint condition for legend row heights based on our discussion in the thursday's call
|
Thanks!! @bnussman-akamai for the approval. Hope @carrillo-erik you are reviewing this PR further. |
Cloud Manager UI test results🎉 455 passing tests on test run #8 ↗︎
|
jaalah-akamai
approved these changes
Nov 27, 2024
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 31m 40s |
| Commit |
|
| Committer | Nikhil Agrawal |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
6
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
461
|
| View all changes introduced in this branch ↗︎ | |
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Fixed some recharts related issues found post migration from Chart JS to Recharts in Cloudpulse
Changes 🔄
List any change(s) relevant to the reviewer.
Target release date 🗓️
10 Dec 2024
Preview 📷
Include a screenshot or screen recording of the change.
🔒 Use the Mask Sensitive Data setting for security.
💡 Use
<video src="" />tag when including recordings in table.Screen.Recording.2024-11-25.at.3.44.39.PM.mov
Screen.Recording.2024-11-25.at.3.45.11.PM.mov
How to test 🧪
Go to monitor tab & switch to mock user
monitor/services/:serviceType/metricsand you'll notice with full & half size widget, you'll see only one tick while in the current alpha version it is generating 2 ticks while moving from half size to full size widgetAs an Author, I have considered 🤔
As an Author, before moving this PR from Draft to Open, I confirmed ✅