upcoming: [M3-8869] - Update types for NodeBalancer UDP support #11321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
dwiley-akamai and
hana-akamai
and removed request for
a team
|
Coverage Report: ✅ |
dwiley-akamai
approved these changes
Dec 3, 2024
packages/manager/.changeset/pr-11321-tech-stories-1733243149867.md
Outdated
Show resolved
Hide resolved
Comment on lines
+210
to
+230
| const client_conn_throttle = number() | ||
| .min( | ||
| CONNECTION_THROTTLE.MIN, | ||
| `Client Connection Throttle must be between ${CONNECTION_THROTTLE.MIN} and ${CONNECTION_THROTTLE.MAX}.` | ||
| ) | ||
| .max( | ||
| CONNECTION_THROTTLE.MAX, | ||
| `Client Connection Throttle must be between ${CONNECTION_THROTTLE.MIN} and ${CONNECTION_THROTTLE.MAX}.` | ||
| ) | ||
| .typeError('Client Connection Throttle must be a number.'); | ||
|
|
||
| const client_udp_sess_throttle = number() | ||
| .min( | ||
| CONNECTION_THROTTLE.MIN, | ||
| `UDP Session Throttle must be between ${CONNECTION_THROTTLE.MIN} and ${CONNECTION_THROTTLE.MAX}.` | ||
| ) | ||
| .max( | ||
| CONNECTION_THROTTLE.MAX, | ||
| `UDP Session Throttle must be between ${CONNECTION_THROTTLE.MIN} and ${CONNECTION_THROTTLE.MAX}.` | ||
| ) | ||
| .typeError('UDP Session Throttle must be a number.'); |
There was a problem hiding this comment.
Can put the error messages that are used twice in their own constants
hana-akamai
approved these changes
Dec 4, 2024
| @@ -116,7 +125,12 @@ export const createNodeBalancerConfigSchema = object({ | |||
| then: (schema) => | |||
| schema.required('SSL certificate is required when using HTTPS.'), | |||
| }), | |||
| stickiness: mixed().oneOf(['none', 'table', 'http_cookie']), | |||
| stickiness: string().when('protocol', { | |||
There was a problem hiding this comment.
Should we also check the following fields when the protocol is udp?
check_passivemust befalseor unsetproxy_protocolmust benoneor unset- The various SSL related fields like
ssl_cert,ssl_key,cipher_suite_recommendedshould not be set modeshould not be specified when creating a node
hana-akamai
added
Approved
Cloud Manager UI test results🎉 466 passing tests on test run #12 ↗︎
|
Cloud Manager E2E
|
||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 28m 26s |
| Commit |
|
| Committer | Banks Nussman |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
465
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/core/billing/smoke-billing-activity.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Billing Activity Feed > displays correct timezone for invoice and payment dates |
Screenshots
Video
|
|
linodes/switch-linode-state.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| switch linode state > powers off a linode from landing page |
Screenshots
Video
|
|
linodes/update-linode-labels.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| update linode label > updates a linode label from the "Settings" tab |
Screenshots
Video
|
|
volumes/create-volume.smoke.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| volumes > does not allow creation of a volume with invalid pricing from volumes landing |
Screenshots
Video
|
|
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Preview 📷
Note
No UI changes
How to test 🧪
M3-8869)As an Author, I have considered 🤔
As an Author, before moving this PR from Draft to Open, I confirmed ✅