Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: [M3-8945] - Update yup from 0.32.9 to 1.4.0 #11324

Merged
merged 8 commits into from
Dec 2, 2024
Merged

refactor: [M3-8945] - Update yup from 0.32.9 to 1.4.0 #11324

merged 8 commits into from
Dec 2, 2024

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Nov 25, 2024 •
edited
Loading

Description 📝

  • Updates our validation library yup to the latest available version 📦
  • This bring improved type-safety, faster type checking, and better .when(...) syntax ✨
  • This should unblock us from updating @hookform/resolvers
  • I mostly just followed this upgrade guide

Preview 📷

Note

There should not be any UI changes

How to test 🧪

  • Verify all automated tests pass ✅
  • Check schemas for faulty/incorrect changes 👀

As an Author, I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@bnussman-akamai bnussman-akamai added Dependencies Pull requests that update a dependency file @linode/validation Changes are made to the @linode/validation package labels Nov 25, 2024
@bnussman-akamai bnussman-akamai self-assigned this Nov 25, 2024
@bnussman-akamai bnussman-akamai marked this pull request as ready for review November 26, 2024 15:59
@bnussman-akamai bnussman-akamai requested review from a team as code owners November 26, 2024 15:59
@bnussman-akamai bnussman-akamai requested review from jdamore-linode, carrillo-erik and harsh-akamai and removed request for a team November 26, 2024 15:59
jdamore-linode
jdamore-linode approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bnussman-akamai! Double checked and confirmed that OBJ test is passing locally

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

Coverage Report: ✅
Base Coverage: 86.95%
Current Coverage: 86.95%

jaalah-akamai
jaalah-akamai approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty 🚀

@jaalah-akamai jaalah-akamai added the Approved Multiple approvals and ready to merge! label Nov 27, 2024
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 462 passing tests on test run #8 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing462 Passing2 Skipped90m 38s

@bnussman-akamai bnussman-akamai merged commit 8c11b28 into linode:develop Dec 2, 2024
23 checks passed
@cypress Cypress
Copy link

cypress bot commented Dec 2, 2024

Cloud Manager E2E    Run #6902

Run Properties:  status check passed Passed #6902  •  git commit 8c11b28580: refactor: [M3-8945] - Update `yup` from `0.32.9` to `1.4.0` (#11324)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6902
Run duration 30m 24s
Commit git commit 8c11b28580: refactor: [M3-8945] - Update `yup` from `0.32.9` to `1.4.0` (#11324)
Committer Banks Nussman
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 6
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 462
View all changes introduced in this branch ↗︎

This was referenced Dec 5, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaalah-akamai jaalah-akamai jaalah-akamai approved these changes

@jdamore-linode jdamore-linode jdamore-linode approved these changes

@carrillo-erik carrillo-erik Awaiting requested review from carrillo-erik carrillo-erik is a code owner automatically assigned from linode/frontend

@harsh-akamai harsh-akamai Awaiting requested review from harsh-akamai harsh-akamai is a code owner automatically assigned from linode/frontend

Assignees

@bnussman-akamai bnussman-akamai

Labels
Approved Multiple approvals and ready to merge! Dependencies Pull requests that update a dependency file @linode/validation Changes are made to the @linode/validation package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bnussman-akamai @linode-gh-bot @jdamore-linode @jaalah-akamai @bnussman