feat: [M3-8953] - Object Storage Gen2 Updates and Improvements #11355

jaalah-akamai · 2024-12-03T14:39:30Z

Changes 🔄

AccessKey: Updated the "Regions/S3 Hostnames" view to align with the new design guidelines, improving how we display multiple region hostnames.
Non-Gen2 Capability Users: Fixed the Properties tab visibility to respect Object Storage capabilities instead of relying on feature flags.
- Added new e2e bucket-details.spec.ts to cover this
getAllBucketsFromEndpoints: Fixed issue where duplicate buckets were being displayed for regions with more than one endpoint
🐛 Removed CORS toggle at the object-level. This was a bug that was doing nothing.

Target release date 🗓️

12/10

Preview 📷

Before	After

How to test 🧪

Verification steps

Access Key

Log in to dev account
Go to /object-storage/
Go to /object-storage/access-keys and observe new "Regions/S3 Hostnames" format | +x regions | Show All {copy icon}

Non-Gen2 Capabilities

Log into a dev test account 007
Go to /object-storage/ and go to any bucket detail page
Observe that you can no longer see the properties tab (Gen 2 feature)

Landing page and Create Access Key

Confirm that duplicate buckets no longer appear in the landing page and in the drawer to create an access key (for Newark buckets)

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

All unit tests are passing
TypeScript compilation succeeded without errors
Code passes all linting rules

packages/manager/src/queries/object-storage/requests.ts

packages/manager/cypress/e2e/core/objectStorage/bucket-details.spec.ts

jaalah-akamai · 2024-12-04T02:37:15Z

packages/manager/cypress/e2e/core/objectStorageGen2/bucket-create-gen2.spec.ts

@@ -356,9 +353,6 @@ describe('Object Storage Gen2 create bucket tests', () => {
          .click();
      });

-    // Wait for the newly 'created' mocked bucket to appear
-    cy.wait(['@getBuckets']);


So this was the culprit. We need to investigate why this wasn't an issue beforehand. 🤔

coliu-akamai · 2024-12-04T16:45:53Z

without the gen2 account capability: sometimes, when I'm on a gen1 bucket, I first see the Bucket Rate Limits table in the SSL/TLS tab. It goes back to the expected SSL/TLS content after I reload. Is anyone else seeing this?

this happens when the obj gen2 flag status is { enabled: true, beta: true }
(I don't see the rate limits table in the SSL/TLS tab when flag.enabled = false)

packages/manager/src/features/ObjectStorage/BucketDetail/index.tsx

@coliu-akamai

…pability users @coliu-akamai

dwiley-akamai

When there's only one access key region, it looks like we have an extra copy icon displaying:

When there are two access key regions, we're showing +1 regions when it should be singular:

packages/manager/.changeset/pr-11355-upcoming-features-1733237339445.md

…339445.md Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

coliu-akamai

tested obj gen 2 throughout this week + confirming bugs listed here are fixed - thanks Jaalah!

heads up, there are some failing unit tests with HostnameTableCell and AccessSelect that need to be resolved

packages/manager/cypress/e2e/core/objectStorage/bucket-details.spec.ts

...ges/manager/src/features/ObjectStorage/AccessKeyLanding/AccessKeyTable/HostNameTableCell.tsx

bnussman-akamai · 2024-12-04T20:20:01Z

packages/manager/src/features/ObjectStorage/BucketDetail/AccessSelect.tsx

@@ -47,10 +47,10 @@ export const AccessSelect = React.memo((props: Props) => {

  const { close: closeDialog, isOpen, open: openDialog } = useOpenClose();
  const label = capitalize(variant);
+
+  // CORS is only available at a bucket level, not at an object level.


Thanks for this fix! 🙏

bnussman-akamai · 2024-12-04T20:26:42Z

packages/manager/src/queries/object-storage/requests.ts

I didn't test this super thoroughly, but logic looks okay

…ccessKeyTable/HostNameTableCell.tsx Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>

abailly-akamai

Logic and UI look good on my end ✅

Access Keys queries ran extremely slow but I'll attribute this to alpha

jaalah-akamai · 2024-12-04T20:35:35Z

@bnussman-akamai thanks looks better

jdamore-linode

I could not figure out what caused those cy.wait('@getBuckets') calls to start triggering test failures 🤔 hoping to revisit soon but didn't want to waste anymore time holding this up

linode-gh-bot · 2024-12-04T21:23:47Z

Cloud Manager UI test results

🔺 2 failing tests on test run #18 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
`2 Failing`	`464 Passing`	`2 Skipped`	`108m 33s`

Details

Failing Tests
	Spec	Test
❌	`bucket-object-gen2.spec.ts`	Object Storage Gen2 bucket object tests » can check Object details drawer with E0 endpoint type
❌	`bucket-object-gen2.spec.ts`	Object Storage Gen2 bucket object tests » can check Object details drawer with E1 endpoint type

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/objectStorageGen2/bucket-object-gen2.spec.ts,cypress/e2e/core/objectStorageGen2/bucket-object-gen2.spec.ts"

jaalah-akamai · 2024-12-04T21:34:13Z

E2E	Unit	Unit

github-actions · 2024-12-04T22:02:30Z

Coverage Report: ✅
Base Coverage: 86.85%
Current Coverage: 86.85%

cypress · 2024-12-04T22:03:01Z

Cloud Manager E2E Run #6921

Run Properties: Passed #6921 • 760950743b: feat: [M3-8953] - Object Storage Gen2 Updates and Improvements (#11355)

Project	`Cloud Manager E2E`
Branch Review	`develop`
Run status	`Passed #6921`
Run duration	`29m 51s`
Commit	`760950743b: feat: [M3-8953] - Object Storage Gen2 Updates and Improvements (#11355)`
Committer	`Jaalah Ramos`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`3`
Pending	`2`
Skipped	`0`
Passing	`466`
View all changes introduced in this branch ↗︎

feat: [M3-8953] - OBJ Gen2 Updates

d4e7851

jaalah-akamai self-assigned this Dec 3, 2024

jaalah-akamai added the Object Storage Gen2 label Dec 3, 2024

Add changeset

e03a55e

jaalah-akamai changed the title ~~feat: [M3-8953] - OBJ Gen2 Updates~~ feat: [M3-8953] - Enhance multi-region hostname display for Object Storage endpoints Dec 3, 2024

coliu-akamai self-requested a review December 3, 2024 15:43

jaalah-akamai changed the title ~~feat: [M3-8953] - Enhance multi-region hostname display for Object Storage endpoints~~ feat: [M3-8953] - Object Storage Gen2 Updates and Improvements Dec 3, 2024

fix duplicate buckets landing page, may rework

4d7799e

coliu-akamai reviewed Dec 3, 2024

View reviewed changes

packages/manager/src/queries/object-storage/requests.ts Outdated Show resolved Hide resolved

jaalah added 5 commits December 3, 2024 15:22

Update e2e tests

15e7bef

Merge branch 'develop' of github.com:linode/manager into M3-8953

9559a04

Merge branch 'M3-8953' of github.com:jaalah-akamai/manager into M3-8953

25f82d6

Remove redundant beforeEach

82da5de

Small adjustment to request

0bd1c2c

jaalah-akamai commented Dec 3, 2024

View reviewed changes

packages/manager/cypress/e2e/core/objectStorage/bucket-details.spec.ts Outdated Show resolved Hide resolved

fix access keys e2e test

bcbe015

jaalah-akamai marked this pull request as ready for review December 3, 2024 23:07

jaalah-akamai requested review from a team as code owners December 3, 2024 23:07

jaalah-akamai requested review from jdamore-linode, bnussman-akamai and coliu-akamai and removed request for a team December 3, 2024 23:07

jaalah-akamai added the Ready for Review label Dec 3, 2024

Fix bucket-create-gen2.spec.ts failing tests @linode/frontend-sdet

7f40ea4

jaalah-akamai commented Dec 4, 2024

View reviewed changes

E2E review updates @cliu-akamai @AzureLatte

7edebf9

coliu-akamai reviewed Dec 4, 2024

View reviewed changes

packages/manager/src/features/ObjectStorage/BucketDetail/index.tsx Show resolved Hide resolved

jaalah added 2 commits December 4, 2024 12:02

Fix issue where properties content was overriding SSL for non-gen2 ca…

597f46b

…pability users @coliu-akamai

Remove CORS from object drawers @bnussman-akamai

26170f4

dwiley-akamai reviewed Dec 4, 2024

View reviewed changes

packages/manager/.changeset/pr-11355-upcoming-features-1733237339445.md Outdated Show resolved Hide resolved

packages/manager/.changeset/pr-11355-upcoming-features-1733237339445.md Outdated Show resolved Hide resolved

jaalah-akamai and others added 4 commits December 4, 2024 14:49

Update packages/manager/.changeset/pr-11355-upcoming-features-1733237…

03297f6

…339445.md Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

Update packages/manager/.changeset/pr-11355-upcoming-features-1733237…

ad14035

…339445.md Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

Remove double copy icon @dwiley-akamai

1edce89

Add changesets

8755f08

coliu-akamai approved these changes Dec 4, 2024

View reviewed changes

packages/manager/cypress/e2e/core/objectStorage/bucket-details.spec.ts Show resolved Hide resolved

bnussman-akamai approved these changes Dec 4, 2024

View reviewed changes

Update packages/manager/src/features/ObjectStorage/AccessKeyLanding/A…

0a0bfa5

…ccessKeyTable/HostNameTableCell.tsx Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>

abailly-akamai approved these changes Dec 4, 2024

View reviewed changes

Pluralize the regions

915e201

Fix E2E based in pluralize

d1d97d6

jdamore-linode approved these changes Dec 4, 2024

View reviewed changes

coliu-akamai added the Approved Multiple approvals and ready to merge! label Dec 4, 2024

dwiley-akamai approved these changes Dec 4, 2024

View reviewed changes

Fix unit tests

2a0bb8c

Fix e2e from removing toggle

c67db09

jaalah-akamai merged commit 7609507 into linode:develop Dec 4, 2024
18 of 21 checks passed

This was referenced Dec 5, 2024

Release v1.133.0 - release → staging #11377

Merged

Release v1.133.0 - staging → master #11378

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [M3-8953] - Object Storage Gen2 Updates and Improvements #11355

feat: [M3-8953] - Object Storage Gen2 Updates and Improvements #11355

jaalah-akamai commented Dec 3, 2024 •

edited

Loading

jaalah-akamai Dec 4, 2024

coliu-akamai commented Dec 4, 2024

dwiley-akamai left a comment

coliu-akamai left a comment

bnussman-akamai Dec 4, 2024

bnussman-akamai Dec 4, 2024

abailly-akamai left a comment

jaalah-akamai commented Dec 4, 2024

jdamore-linode left a comment

linode-gh-bot commented Dec 4, 2024

jaalah-akamai commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

cypress bot commented Dec 4, 2024

feat: [M3-8953] - Object Storage Gen2 Updates and Improvements #11355

feat: [M3-8953] - Object Storage Gen2 Updates and Improvements #11355

Conversation

jaalah-akamai commented Dec 3, 2024 • edited Loading

Changes 🔄

Target release date 🗓️

Preview 📷

How to test 🧪

Verification steps

As an Author, to speed up the review process, I considered 🤔

As an Author, before moving this PR from Draft to Open, I confirmed ✅

jaalah-akamai Dec 4, 2024

Choose a reason for hiding this comment

coliu-akamai commented Dec 4, 2024

dwiley-akamai left a comment

Choose a reason for hiding this comment

coliu-akamai left a comment

Choose a reason for hiding this comment

bnussman-akamai Dec 4, 2024

Choose a reason for hiding this comment

bnussman-akamai Dec 4, 2024

Choose a reason for hiding this comment

abailly-akamai left a comment

Choose a reason for hiding this comment

jaalah-akamai commented Dec 4, 2024

jdamore-linode left a comment

Choose a reason for hiding this comment

linode-gh-bot commented Dec 4, 2024

Cloud Manager UI test results

🔺 2 failing tests on test run #18 ↗︎

Details

Troubleshooting

jaalah-akamai commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

cypress bot commented Dec 4, 2024

Cloud Manager E2E Run #6921

jaalah-akamai commented Dec 3, 2024 •

edited

Loading