-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-8848] - Update Kubernetes version Autocomplete to filter on LKE-E versions #11359
upcoming: [M3-8848] - Update Kubernetes version Autocomplete to filter on LKE-E versions #11359
Conversation
… support tiers for LKE-E
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mariah, the test is looking good! I really like how you're building it out piece-by-piece alongside the rest of the feature work.
I am seeing some rare failures when running it repeatedly, but couldn't figure out if it's a test issue or an app issue. I posted a comment with everything I know. Hoping to take a closer look in the next day or so, but happy to help out if you have any questions, trouble reproducing, etc.!
Forgot to fix this after I was messing around with things Co-authored-by: jdamore-linode <97627410+jdamore-linode@users.noreply.github.com>
packages/manager/src/features/Kubernetes/CreateCluster/CreateCluster.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Kubernetes/CreateCluster/CreateCluster.tsx
Outdated
Show resolved
Hide resolved
Coverage Report: ✅ |
…atest versions
Cloud Manager UI test results🎉 467 passing tests on test run #8 ↗︎
|
Tests looking stable and any further UX enhancements saved (M3-8922) until we have a better idea of any versioning API updates coming from the backend, this PR is good for re-review as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
- Confirm the following with the feature flag ON:
- The version select shows the latest standard LKE version by default (e.g. 1.31)
- When the user selects
LKE Enterprise
as their cluster type, the version select shows only LKE-E versions - The user can toggle back to standard versions by selecting
LKE
as the cluster type - The user can create an enterprise cluster by selecting a region in which LKE-E is available (e.g. Chicago), a current enterprise k8 version, and submitting the form
- The user can create a standard cluster by selection any region, a current standard k8 version, and submitting the form
- Confirm the following with the feature flag OFF:
- No regressions to the version select and the existing endpoint (
/versions
) is used - No regressions to the user's ability to create an LKE cluster
- No regressions to the version select and the existing endpoint (
- Confirm test coverage passes:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much cleaner, thank you for handling these changes!
Confirming code and functionality ✅
Cloud Manager E2E Run #6954
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Passed #6954
|
Run duration | 29m 06s |
Commit |
61987af87d: upcoming: [M3-8848] - Update Kubernetes version Autocomplete to filter on LKE-E ...
|
Committer | Mariah Jacobs |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
2
|
Pending |
2
|
Skipped |
0
|
Passing |
469
|
View all changes introduced in this branch ↗︎ |
Description 📝
When a user selects LKE-Enterprise as their cluster type, we will need to ensure the Kubernetes versions for the enterprise tier are displayed and the versions for the standard tier are not.
Note: UX has noted that there is a potential drop off at the version field in LKE during cluster creation. Potential helper text/tooltip may be added. Update: this will be done in M3-8992, dependent on what docs we link (and where) to help.
Changes 🔄
return
in the useKubernetesTieredVersionsQuery hooktier
if the LKE-E feature is enabled so that the enterprise cluster can be createdlke-create.spec.ts
Preview 📷
Screen.Recording.2024-12-03.at.8.37.00.AM.mov
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
LKE Enterprise
as their cluster type, the version select shows only LKE-E versionsLKE
as the cluster type/versions
) is usedAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅