feat: [M3-8931] - Add doc link and region availability banner for Accelerated plans #11363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coliu-akamai
requested review from
cpathipa,
pmakode-akamai and
abailly-akamai
and removed request for
a team
…ated compute plans
coliu-akamai
commented
Dec 3, 2024
Comment on lines
+30
to
+32
| // TODO: accelerated plans - update to GA link (when GA launches) | ||
| export const ACCELERATED_COMPUTE_INSTANCES_LINK = | ||
| 'https://techdocs.akamai.com/cloud-computing/docs/accelerated-compute-instances-beta'; |
There was a problem hiding this comment.
created [M3-8962] to update docs link (+ setting a reminder/event for myself to remember)
| } | ||
| variant="warning" | ||
| > | ||
| <Notice spacingBottom={8} variant="warning"> |
There was a problem hiding this comment.
(going back to the original spacingBottom, now that we're introducing the region availability notice)
coliu-akamai
requested review from
cliu-akamai
and removed request for
a team
|
Coverage Report: ✅ |
|
@coliu-akamai how do you feel about removing the transfer banner if the region has no availability?
It could be a follow up - not a blocker since this is what we do for GPU plans too |
bnussman-akamai
approved these changes
Dec 3, 2024
|
@abailly-akamai created [M3-8963] to check with UX about removing this banner for regions where it's not available |
Cloud Manager UI test results🔺 1 failing test on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/linodes/update-linode-labels.spec.ts" |
|||||||||||||||||
pmakode-akamai
approved these changes
Dec 4, 2024
cpathipa
approved these changes
Dec 4, 2024
|
test passed locally - merging |
Cloud Manager E2E
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 29m 14s |
| Commit |
|
| Committer | Connie Liu |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
1
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
464
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/core/linodes/update-linode-labels.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| update linode label > updates a linode label from the "Settings" tab |
Screenshots
Video
|
|
cypress/e2e/core/linodes/linode-config.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Linode Config management > End-to-End > Clones a config |
Screenshots
Video
|
|
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Target release date 🗓️
12/10 - must be in for 12/10 release
Preview 📷
Include a screenshot or screen recording of the change.
🔒 Use the Mask Sensitive Data setting for security.
💡 Use
<video src="" />tag when including recordings in table.How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅