refactor: [M3-8964] - Remove reselect dependency
#11364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
added
Dependencies
bnussman-akamai
requested review from
dwiley-akamai and
harsh-akamai
and removed request for
a team
|
Coverage Report: ✅ |
Cloud Manager UI test results🎉 465 passing tests on test run #4 ↗︎
|
harsh-akamai
approved these changes
Dec 5, 2024
dwiley-akamai
approved these changes
Dec 6, 2024
bnussman-akamai
added
Approved
Cloud Manager E2E
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 34m 28s |
| Commit |
|
| Committer | Banks Nussman |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
2
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
464
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
linodes/linode-config.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Linode Config management > End-to-End > Clones a config |
Screenshots
Video
|
|
billing/smoke-billing-activity.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Billing Activity Feed > displays correct timezone for invoice and payment dates |
Screenshots
Video
|
|
linodes/switch-linode-state.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| switch linode state > powers on a linode from landing page |
Screenshots
Video
|
|
linodes/resize-linode.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| resize linode > resizes a linode by increasing size when offline: cold migration |
Screenshots
Video
|
|
linodes/clone-linode.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| clone linode > can clone a Linode from Linode details page |
Screenshots
Video
|
|
firewalls/update-firewall.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| update firewall > updates a firewall's linodes and rules |
Screenshots
Video
|
|
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
reselectdependency 📦How to test 🧪
yarn.lockchanges look correctreselectisn't used anywhereAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅