feat: [UIE-8136] - IAM RBAC: add new users table component (part 1) #11367
Conversation
aaleksee-akamai
requested review from
mjac0bs and
hana-akamai
and removed request for
a team
aaleksee-akamai
force-pushed
the
UIE-8136-iam-rbac-users-table-part-1
branch
from
290bd8e to
e1707ba
Compare
|
Coverage Report: ✅ |
aaleksee-akamai
force-pushed
the
UIE-8136-iam-rbac-users-table-part-1
branch
from
e1707ba to
20f9781
Compare
There was a problem hiding this comment.
Thanks for this contribution, @aaleksee-akamai!
Requesting changes for a few relatively small bits of feedback here.
In addition to the inline feedback, we'll want to address the linting warnings present in most files. Expand the accordion below for screenshots of most of them. We strongly recommend an es-lint extension to help catch and fix these easily (developer docs).
Requires Linting
In the future, please keep the How to Test section of the pull request template in your PR description. It helps anyone on the team easily test the PR at a glance when by calling out how to set up the environment and what reviewers should look out for (and what you confirmed yourself) there. For example, since this PR is pretty straight forward: "Ensure the Identity and Access Beta flag is enabled in dev tools", "Confirm table renders. Confirm correct columns are shown at smaller screen sizes. Confirm loading state at all screen sizes".
| }, | ||
| }); | ||
|
|
||
| const numCols = 4; |
There was a problem hiding this comment.
We're going to need to make this dynamic to account for hidden columns at smaller screen sizes.
A good way to test this is to make use of the React Query dev tools. I find it helpful to 'Trigger Loading' action for an endpoint and then resize the screen to check that loading (and error) states are handled correctly.
Screen.Recording.2024-12-09.at.7.19.39.PM.mov
There was a problem hiding this comment.
thanks @mjac0bs , i didn't know about this tools, your video helped me to do that!
packages/manager/src/features/IAM/Users/UsersTable/UsersLandingTableHead.tsx
Outdated
Show resolved
Hide resolved
aaleksee-akamai
force-pushed
the
UIE-8136-iam-rbac-users-table-part-1
branch
from
26e0e7c to
e11b9ef
Compare
|
thanks for the review, @mjac0bs! sure, I won't remove this section with how to test in the future. In addition, I've fixed the linting warnings in my changes. |
Cloud Manager UI test results🎉 465 passing tests on test run #5 ↗︎
|
| @@ -0,0 +1,117 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Thank you for adding test coverage
There was a problem hiding this comment.
Thanks for addressing feedback, @aaleksee-akamai! This all looks good now. I'm going to go ahead and merge since the last thing I committed was just a changeset file rename, and all tests passed previously.
mjac0bs
added
Approved
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 29m 22s |
| Commit |
|
| Committer | aaleksee-akamai |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
467
|
| View all changes introduced in this branch ↗︎ | |
Description 📝
IAM RBAC - users table component.
Adds the component itself, which is a copy of an existing one in the
Account, with some adjustments.Second PR (part 2) will include the table for proxy users and the logic for deleting and filtering them.
Changes 🔄
Target release date 🗓️
Dec 10, 2024 (dev)
Preview 📷
Include a screenshot or screen recording of the change.
🔒 Use the Mask Sensitive Data setting for security.
💡 Use
<video src="" />tag when including recordings in table.Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅