feat: [UIE-8269], [UIE-8290] - DBaaS: Access Controls text update, fix defaultDB for legacy instances #11371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpolotsk-akamai
requested review from
dwiley-akamai and
coliu-akamai
and removed request for
a team
|
Coverage Report: ✅ |
cpathipa
approved these changes
Dec 4, 2024
packages/manager/src/features/Databases/DatabaseDetail/AddAccessControlDrawer.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseDetail/AddAccessControlDrawer.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseDetail/DatabaseSettings/DatabaseSettings.tsx
Outdated
Show resolved
Hide resolved
…x defaultDB for legacy instances
mpolotsk-akamai
force-pushed
the
UIE-8269-default-db
branch
from
9cb5061 to
f6ac765
Compare
mpolotsk-akamai
requested review from
cliu-akamai
and removed request for
a team
…in Access Controls, fixed default DB value for legacy instances
dwiley-akamai
approved these changes
Dec 5, 2024
jdamore-linode
requested changes
Dec 5, 2024
There was a problem hiding this comment.
@mpolotsk-akamai It looks like these changes may have broken the DBaaS update tests. Mind taking care of that before we merge? cc @cpathipa
|
Yes, Just verified failed tests are passed in develop, But failed on this PR @mpolotsk-akamai Could you please take a look. |
Cloud Manager UI test results🎉 466 passing tests on test run #12 ↗︎
|
jdamore-linode
approved these changes
Dec 5, 2024
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 28m 55s |
| Commit |
|
| Committer | mpolotsk-akamai |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
466
|
| View all changes introduced in this branch ↗︎ | |
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
DBaaS: Access Controls text update, fix defaultDB for legacy instances
Changes 🔄
Target release date 🗓️
12/10/24
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅