Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poc: Enforce more linting #11372

Closed
wants to merge 6 commits into from
Closed

poc: Enforce more linting #11372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ad2d6be
intial changes
bnussman Dec 4, 2024
4823c34
should not typecheck
bnussman Dec 4, 2024
468e79b
make prettier error
bnussman Dec 4, 2024
96db6bc
try without quiet
bnussman Dec 4, 2024
4b2b000
fix linting issue
bnussman Dec 4, 2024
9f0effb
the pre-commit hooks on this commit should fix the prettier issue
bnussman Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/manager/.eslintrc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ module.exports = {
'perfectionist/sort-objects': 'warn',
'perfectionist/sort-union-types': 'warn',
// make prettier issues warnings
'prettier/prettier': 'warn',
'prettier/prettier': 'error',
// radix requires to give the base in parseInt https://eslint.org/docs/rules/radix
radix: 'error',
// ramda
Expand Down
7 changes: 2 additions & 5 deletions packages/manager/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
"start": "concurrently --raw \"NODE_OPTIONS='--max-old-space-size=4096' vite\" \"NODE_OPTIONS='--max-old-space-size=4096' tsc --watch --preserveWatchOutput\"",
"start:expose": "concurrently --raw \"vite --host\" \"tsc --watch --preserveWatchOutput\"",
"start:ci": "vite preview --port 3000 --host",
"lint": "yarn run eslint . --ext .js,.ts,.tsx --quiet",
"lint": "eslint . --ext .js,.ts,.tsx --quiet",
"build": "vite build",
"build:analyze": "bunx vite-bundle-visualizer",
"precommit": "lint-staged && yarn typecheck",
Expand All @@ -112,10 +112,7 @@
"coverage:summary": "vitest run --coverage.enabled --reporter=junit --coverage.reporter=json-summary"
},
"lint-staged": {
"*.{ts,tsx,js}": [
"prettier --write",
"eslint --ext .js,.ts,.tsx --quiet"
]
"*.{ts,tsx,js}": "eslint --ext .js,.ts,.tsx --fix"
},
"devDependencies": {
"@linode/eslint-plugin-cloud-manager": "^0.0.5",
Expand Down
Loading