fix: [M3-8847] RegionSelect width #11374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
requested review from
cpathipa,
hkhalil-akamai,
hana-akamai and
dwiley-akamai
and removed request for
a team
bnussman-akamai
approved these changes
Dec 5, 2024
jdamore-linode
approved these changes
Dec 5, 2024
mjac0bs
approved these changes
Dec 5, 2024
|
Oh wait, I see the branch issues. Reopen branching off release-v1.133.0? |
|
@mjac0bs it's all fine, this is meant for develop since we will re-cut a release branch |
|
Yeah, I saw Dajahi's comment in Slack right after I wrote that message. All good, thanks. 👍🏼 |
Cloud Manager E2E
|
||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 28m 55s |
| Commit |
|
| Committer | Alban Bailly |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
465
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/core/volumes/delete-volume.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| volume delete flow > deletes a volume |
Screenshots
Video
|
|
switch-linode-state.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| switch linode state > powers off a linode from details page |
Screenshots
Video
|
|
linode-config.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Linode Config management > End-to-End > Clones a config |
Screenshots
Video
|
|
update-linode-labels.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| update linode label > updates a linode label from details page |
Screenshots
Video
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
fix to a regression introduced in https://github.com/linode/manager/pull/11348/files#diff-53966653a902407c449c1ebecc270efaa4bb9b0f8f1eac2c925cbf5bc2eb4268R124
no need for changeset since it was just merged to develop
Changes 🔄
How to test 🧪
Prerequisites
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅