Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-8847] RegionSelect width #11375

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Dec 5, 2024

Description 📝

fix to a regression introduced in https://github.com/linode/manager/pull/11348/files#diff-53966653a902407c449c1ebecc270efaa4bb9b0f8f1eac2c925cbf5bc2eb4268R124

no need for changeset since it was just merged to develop

Changes 🔄

  • restore RegionSelect width

How to test 🧪

Prerequisites

Verification steps

  • check wherever RegionSelect is implemented (linode create etc)
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@abailly-akamai abailly-akamai changed the title Fix region select width fix: [M3-8847] RegionSelect width Dec 5, 2024
@abailly-akamai abailly-akamai marked this pull request as ready for review December 5, 2024 13:55
@abailly-akamai abailly-akamai requested a review from a team as a code owner December 5, 2024 13:55
@abailly-akamai abailly-akamai requested review from bnussman-akamai, pmakode-akamai, hana-akamai and dwiley-akamai and removed request for a team December 5, 2024 13:55
@abailly-akamai abailly-akamai self-assigned this Dec 5, 2024
@abailly-akamai abailly-akamai added the Bug Fixes for regressions or bugs label Dec 5, 2024
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fixes for regressions or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants