Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-8796] - Disallow word-break in billing contact info #11379

Conversation

hasyed-akamai
Copy link
Contributor

Description 📝

We are preventing word breaks in the billing contact information to improve layout and readability.

Changes 🔄

  • Disabled word breaks in billing contact info.

Target release date 🗓️

N/A

Preview 📷

Before After
Before After

How to test 🧪

Prerequisites

  • Ensure a billing contact info is saved in the account.

Reproduction steps

  • Log in and go to the Account Page.
  • Check if the billing info is displayed without word breaks.

Verification steps

  • Ensure the billing info is shown without line breaks.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hasyed-akamai hasyed-akamai self-assigned this Dec 6, 2024
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing464 Passing2 Skipped101m 5s

Details

Failing Tests
SpecTest
create-linode-from-image.spec.tscreate linode from image, mocked data » creates linode from image on images tab
create-linode-from-image.spec.tscreate linode from image, mocked data » creates linode from preselected image on images tab

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/images/create-linode-from-image.spec.ts,cypress/e2e/core/images/create-linode-from-image.spec.ts"

@harsh-akamai harsh-akamai marked this pull request as ready for review December 9, 2024 04:22
@harsh-akamai harsh-akamai requested a review from a team as a code owner December 9, 2024 04:22
@harsh-akamai harsh-akamai requested review from bnussman-akamai and cpathipa and removed request for a team December 9, 2024 04:22
@hasyed-akamai hasyed-akamai added Ready for Review Bug Fixes for regressions or bugs labels Dec 9, 2024
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Dec 9, 2024
@hasyed-akamai hasyed-akamai merged commit 57b884e into linode:develop Dec 10, 2024
22 of 23 checks passed
Copy link

cypress bot commented Dec 10, 2024

Cloud Manager E2E    Run #6941

Run Properties:  status check passed Passed #6941  •  git commit 57b884e3d0: fix: [M3-8796] - Disallow word-break in billing contact info (#11379)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6941
Run duration 28m 11s
Commit git commit 57b884e3d0: fix: [M3-8796] - Disallow word-break in billing contact info (#11379)
Committer hasyed-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 467
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants