Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-8972] - Overflow issue in Kubernetes Summary section on smaller screens (β†’ staging) #11380

Conversation

pmakode-akamai
Copy link
Contributor

@pmakode-akamai pmakode-akamai commented Dec 6, 2024

Description πŸ“

This PR fixes a minor regression in CM (mobile view/smaller screens only) caused by #11179

Note

Pointing this PR to staging

Preview πŸ“·

Before After
Screenshot 2024-12-06 at 4 18 32β€―PM Screenshot 2024-12-06 at 5 18 07β€―PM

Changes πŸ”„

  • Fixed Summary section Overflow issue
  • Fixed "Summary" header alignment (made responsive)
  • Fixed text alignments and made some other improvements

How to test πŸ§ͺ

  • Ensure no overflow issue in the "Summary" section on smaller devices
Author Checklists

As an Author, to speed up the review process, I considered πŸ€”

πŸ‘€ Doing a self review
❔ Our contribution guidelines
🀏 Splitting feature into small PRs
βž• Adding a changeset
πŸ§ͺ Providing/improving test coverage
πŸ” Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
πŸ‘£ Providing comprehensive reproduction steps
πŸ“‘ Providing or updating our documentation
πŸ•› Scheduling a pair reviewing session
πŸ“± Providing mobile support
β™Ώ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed βœ…

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@pmakode-akamai pmakode-akamai self-assigned this Dec 6, 2024
@pmakode-akamai pmakode-akamai added the Bug Fixes for regressions or bugs label Dec 6, 2024
@pmakode-akamai pmakode-akamai marked this pull request as ready for review December 6, 2024 10:43
@pmakode-akamai pmakode-akamai requested a review from a team as a code owner December 6, 2024 10:43
@pmakode-akamai pmakode-akamai requested review from dwiley-akamai and abailly-akamai and removed request for a team December 6, 2024 10:43
@pmakode-akamai pmakode-akamai changed the title fix: [M3-8972] - overflow issue on kubernetes summary for smaller screens fix: [M3-8972] - Overflow issue on kubernetes summary for smaller screens Dec 6, 2024
@pmakode-akamai pmakode-akamai changed the title fix: [M3-8972] - Overflow issue on kubernetes summary for smaller screens fix: [M3-8972] - Overflow issue in Kubernetes Summary section on smaller screens Dec 6, 2024
@pmakode-akamai pmakode-akamai force-pushed the M3-8972-fix-overflow-issue-on-kubernetes-summary-for-smaller-screens branch from a5fc3a6 to 5841ba2 Compare December 6, 2024 15:14
@pmakode-akamai pmakode-akamai requested a review from a team as a code owner December 6, 2024 15:14
@pmakode-akamai pmakode-akamai requested review from jdamore-linode and removed request for a team December 6, 2024 15:14
@pmakode-akamai pmakode-akamai marked this pull request as draft December 6, 2024 15:17
@pmakode-akamai pmakode-akamai changed the base branch from staging to develop December 6, 2024 15:20
@pmakode-akamai pmakode-akamai marked this pull request as ready for review December 6, 2024 15:20
Copy link

github-actions bot commented Dec 6, 2024

Coverage Report: βœ…
Base Coverage: 86.85%
Current Coverage: 86.85%

dwiley-akamai
dwiley-akamai previously approved these changes Dec 6, 2024
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overflow issues fixed βœ…

You may be able to point this PR at staging to get the fix in for next week's release. cc @hkhalil-akamai

@pmakode-akamai pmakode-akamai changed the base branch from develop to staging December 7, 2024 07:34
@pmakode-akamai pmakode-akamai dismissed dwiley-akamai’s stale review December 7, 2024 07:34

The base branch was changed.

@pmakode-akamai pmakode-akamai changed the base branch from staging to develop December 7, 2024 07:34
@pmakode-akamai pmakode-akamai force-pushed the M3-8972-fix-overflow-issue-on-kubernetes-summary-for-smaller-screens branch from 5841ba2 to 48b23fe Compare December 7, 2024 08:06
@pmakode-akamai pmakode-akamai changed the base branch from develop to staging December 7, 2024 08:07
@pmakode-akamai pmakode-akamai changed the title fix: [M3-8972] - Overflow issue in Kubernetes Summary section on smaller screens fix: [M3-8972] - Overflow issue in Kubernetes Summary section on smaller screens (β†’ staging) Dec 7, 2024
@pmakode-akamai
Copy link
Contributor Author

@dwiley-akamai @hkhalil-akamai The PR is now pointing to β†’ staging. This change requires re-approval.

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

πŸŽ‰ 466 passing tests on test run #19 β†—οΈŽ

❌ Failingβœ… Passingβ†ͺ️ SkippedπŸ• Duration
0 Failing466 Passing2 Skipped109m 40s

@pmakode-akamai pmakode-akamai added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Dec 10, 2024
@jaalah-akamai jaalah-akamai merged commit 500475c into linode:staging Dec 10, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants