Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [DI-20595] - ACLP Supported regions per service type #11381

Closed
wants to merge 11 commits into from

Conversation

ankita-akamai
Copy link
Contributor

Description 📝

ACLP supports a limited set of regions per service type and capability based on LaunchDarkly config. Regions are now correctly filtered according to the capability they belong to and the supported regions fetched from launchDarkly.

Changes 🔄

  1. Added new key for supported regions in aclpResourceType Flag.
  2. Validated the region ids from flag with all the regions fetched from api.
  3. Filtered the service type specific regions using corresponding capabilities.
  4. Added relevant unit test to verify.

Target release date 🗓️

12 December 2024

Preview 📷

How to test 🧪

  1. Navigate to monitor tab.
  2. Select a dashboard.
  3. Open networks tab, find the launchDarkly config, see supported region ids in aclpResourceTypeMap, verify that these are same as the region ids listed in 'regions' autocomplete popper list. In case supportedRegionIds is empty/undefined, all regions per capability will be shown.
    Note: ids are listed at the end of region option label in autocomplete list.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@ankita-akamai ankita-akamai requested a review from a team as a code owner December 6, 2024 09:58
@ankita-akamai ankita-akamai requested review from bnussman-akamai and hkhalil-akamai and removed request for a team December 6, 2024 09:58
Copy link

github-actions bot commented Dec 6, 2024

Coverage Report:
Base Coverage: 86.84%
Current Coverage: 86.84%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants