Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upcoming: [DI-20595] - ACLP Supported regions per service type #11382

Merged
merged 21 commits into from
Dec 11, 2024
Merged

upcoming: [DI-20595] - ACLP Supported regions per service type #11382

merged 21 commits into from
Dec 11, 2024

Conversation

ankita-akamai
Copy link
Contributor

@ankita-akamai ankita-akamai commented Dec 6, 2024 •
edited
Loading

Description 📝

ACLP supports a limited set of regions per service type and capability based on LaunchDarkly config. Regions are now correctly filtered according to the capability they belong to and the supported regions fetched from launchDarkly.

Changes 🔄

  1. Added new key for supported regions in aclpResourceType Flag.
  2. Validated the region ids from flag with all the regions fetched from api.
  3. Filtered the service type specific regions using corresponding capabilities.
  4. Added relevant unit test to verify.

Target release date 🗓️

12 December 2024

Preview 📷

How to test 🧪

  1. Navigate to monitor tab.
  2. Select a dashboard.
  3. Open networks tab, find the launchDarkly config, see supported region ids in aclpResourceTypeMap, verify that these are same as the region ids listed in 'regions' autocomplete popper list. In case supportedRegionIds is null/undefined, all regions per capability will be shown.
    Note: ids are listed at the end of region option label in autocomplete list.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@ankita-akamai ankita-akamai requested a review from a team as a code owner December 6, 2024 11:34
@ankita-akamai ankita-akamai requested review from mjac0bs and pmakode-akamai and removed request for a team December 6, 2024 11:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

Coverage Report: ❌
Base Coverage: 86.89%
Current Coverage: 86.84%

@ankita-akamai
Copy link
Contributor Author

ankita-akamai commented Dec 9, 2024 •
edited
Loading

Update: Please wait for this launchDarkly ticket to get closed in order to test the pr - https://jira.linode.com/browse/M3-8980
[EDIT]: Ticket is done.

@ankita-akamai ankita-akamai requested a review from a team as a code owner December 9, 2024 13:50
@ankita-akamai ankita-akamai requested review from cliu-akamai and removed request for a team December 9, 2024 13:50
mjac0bs
mjac0bs approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that I saw the regions expected based on the LD config.

LD Request Linodes DBaaS
Screenshot 2024-12-09 at 8 36 54 PM Screenshot 2024-12-09 at 8 43 22 PM Screenshot 2024-12-09 at 8 36 48 PM

Approving pending some minor feedback is addressed - thanks, Ankita

packages/manager/src/features/CloudPulse/shared/CloudPulseRegionSelect.tsx Outdated Show resolved Hide resolved
packages/manager/src/features/CloudPulse/shared/CloudPulseRegionSelect.tsx Outdated Show resolved Hide resolved
packages/manager/src/features/CloudPulse/shared/CloudPulseRegionSelect.test.tsx Outdated Show resolved Hide resolved
packages/manager/src/features/CloudPulse/shared/CloudPulseRegionSelect.test.tsx Outdated Show resolved Hide resolved
@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Dec 10, 2024
ankita-akamai and others added 3 commits December 10, 2024 19:34
@ankita-akamai @pmakode-akamai
upcoming: [DI-20595] - linting fix
e74d09f 
Co-authored-by: Purvesh Makode <pmakode@akamai.com>
@ankita-akamai @pmakode-akamai
upcoming: [DI-20595] - linting fix
9edb799 
Co-authored-by: Purvesh Makode <pmakode@akamai.com>
@ankita-akamai @mjac0bs
upcoming: [DI-20595] - linting fix
1cb3c4b 
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 466 passing tests on test run #10 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing466 Passing2 Skipped105m 28s

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Dec 10, 2024
@ankita-akamai
Copy link
Contributor Author

@pmakode-akamai can we merge this pr given that all pr comments are addressed?

@pmakode-akamai
Copy link
Contributor

merging - all checks have passed ✅

@pmakode-akamai pmakode-akamai merged commit 0bd360b into linode:develop Dec 11, 2024
23 checks passed
@cypress Cypress
Copy link

cypress bot commented Dec 11, 2024 •
edited
Loading

Cloud Manager E2E    Run #6952

Run Properties:  status check passed Passed #6952  •  git commit 0bd360b361: upcoming: [DI-20595] - ACLP Supported regions per service type (#11382)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6952
Run duration 27m 52s
Commit git commit 0bd360b361: upcoming: [DI-20595] - ACLP Supported regions per service type (#11382)
Committer Ankita
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 469
View all changes introduced in this branch ↗︎

This was referenced Jan 8, 2025
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmakode-akamai pmakode-akamai pmakode-akamai approved these changes

@nikhagra-akamai nikhagra-akamai nikhagra-akamai approved these changes

@mjac0bs mjac0bs mjac0bs approved these changes

@cliu-akamai cliu-akamai Awaiting requested review from cliu-akamai cliu-akamai is a code owner automatically assigned from linode/frontend-sdet

Assignees

@ankita-akamai ankita-akamai

Labels
Approved Multiple approvals and ready to merge! Cloud Pulse - Dashboards Cloud Pulse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ankita-akamai @linode-gh-bot @pmakode-akamai @mjac0bs @nikhagra-akamai @jaalah-akamai @agorthi-akamai