Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8693] - Cypress tests for Credit Card Expired banner #11383

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

hkhalil-akamai
Copy link
Contributor

Changes 🔄

  • Adds Cypress tests for the Credit Card Expired banner.
  • Mocks the account endpoint with an expired and non-expired credit card.
  • Verifies clicking the "Update Card" button navigates to account/billing.

How to test 🧪

  1. yarn cy:run -s "cypress/e2e/core/billing/credit-card-expired-banner.spec.ts"

  2. Verify CI passes

@hkhalil-akamai hkhalil-akamai added the e2e Indicates that a PR touches Cypress tests in some way label Dec 6, 2024
@hkhalil-akamai hkhalil-akamai self-assigned this Dec 6, 2024
@hkhalil-akamai hkhalil-akamai requested a review from a team as a code owner December 6, 2024 22:16
@hkhalil-akamai hkhalil-akamai requested review from AzureLatte and removed request for a team December 6, 2024 22:16
@hkhalil-akamai hkhalil-akamai requested a review from a team as a code owner December 6, 2024 22:17
@hkhalil-akamai hkhalil-akamai requested review from carrillo-erik and coliu-akamai and removed request for a team December 6, 2024 22:17
Copy link

github-actions bot commented Dec 6, 2024

Coverage Report:
Base Coverage: 86.84%
Current Coverage: 86.84%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing467 Passing2 Skipped104m 46s

Details

Failing Tests
SpecTest
smoke-billing-activity.spec.tsBilling Activity Feed » displays correct timezone for invoice and payment dates

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/billing/smoke-billing-activity.spec.ts"

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ confirmed test passes! thanks Hussain

test failure looks unrelated, although I was seeing the same issue on local - the default timezone is already EST - NY on the test account (and my account), so retyping in EST - NY doesn't change the field's value or enable the button:

image

do you know if this test is only recently failing? wonder if there were any changes to cause this

@coliu-akamai coliu-akamai added the Add'tl Approval Needed Waiting on another approval! label Dec 9, 2024
Copy link
Contributor

@AzureLatte AzureLatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passes

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Dec 10, 2024
@hkhalil-akamai hkhalil-akamai merged commit d0fb914 into linode:develop Dec 10, 2024
22 of 23 checks passed
@hkhalil-akamai hkhalil-akamai deleted the M3-8693-cc-banner-test branch December 10, 2024 18:38
Copy link

cypress bot commented Dec 10, 2024

Cloud Manager E2E    Run #6947

Run Properties:  status check passed Passed #6947  •  git commit d0fb9149a0: test: [M3-8693] - Cypress tests for Credit Card Expired banner (#11383)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6947
Run duration 29m 01s
Commit git commit d0fb9149a0: test: [M3-8693] - Cypress tests for Credit Card Expired banner (#11383)
Committer Hussain Khalil
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 469
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! e2e Indicates that a PR touches Cypress tests in some way
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants