Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-8905] - Change document title from address to appropriate keyword #11385

Conversation

hasyed-akamai
Copy link
Contributor

@hasyed-akamai hasyed-akamai commented Dec 9, 2024

Description 📝

This PR fixes the issue where the page title on certain landing pages (e.g., Domain Landing, Object Storage Detail pages, and StackScripts details pages) was incorrectly set to the page's URL instead of displaying the expected title with relevant keywords

Changes 🔄

List any change relevant to the reviewer.

  • Updated the page title to display relevant keywords instead of the page's URL on the affected landing pages.

Target release date 🗓️

N/A

Preview 📷

Before After
Before After
Before After
Before After
Before After
Before After
Before After
Before After
Before After
Before After
Before After
Before After
Before After
Before After

How to test 🧪

Prerequisites

  • Ensure you have at least one Object Storage bucket and StackScript configured. The configuration of the bucket or other resources does not matter.

Reproduction steps

  • Navigate to the Cloud Manager Domain Landing page, Object Storage Landing page, or StackScript details page.
  • Click on the relevant item (e.g., a bucket or a stack script).
  • Observe the page title in the browser window or tab.

Verification steps

  • The page title should display the relevant keywords for the page not the URL.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hasyed-akamai hasyed-akamai added the Bug Fixes for regressions or bugs label Dec 9, 2024
@hasyed-akamai hasyed-akamai self-assigned this Dec 9, 2024
Copy link
Contributor

@harsh-akamai harsh-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it would be better if we could display the feature along with the bucket/stackscript label. For ex: obj-bucket-label | Bucket | Akamai Cloud Manager

@harsh-akamai harsh-akamai marked this pull request as ready for review December 10, 2024 07:42
@harsh-akamai harsh-akamai requested a review from a team as a code owner December 10, 2024 07:42
@harsh-akamai harsh-akamai requested review from mjac0bs and pmakode-akamai and removed request for a team December 10, 2024 07:42
Copy link

github-actions bot commented Dec 10, 2024

Coverage Report:
Base Coverage: 86.78%
Current Coverage: 86.89%

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Confirmed that empty state Domains Landing, OBJ Bucket Detail, and StackScripts Detail were showing correct keywords.

I also clicked around the app to see if I could find any other places where this was an issue. I did find a few more inconsistencies.

  • Billing invoice details pages (e.g. https://cloud.linode.com/account/billing/invoices/28083993) - Let's definitely fix this. Can we make it Invoice | Account & Billing?
    Screenshot 2024-12-10 at 3 19 22 PM

  • Kubernetes cluster details pages - This would be ideal to fix because the cluster name comes after the "Kubernetes Cluster", which is different from how we identify entities on all other pages. We should have <cluster-label> | Kubernetes Cluster.
    Screenshot 2024-12-10 at 3 18 31 PM

  • Databases details pages - I'm not quite what's best for these pages, to be honest. On the Linode details page (e.g. <linode label> - Storage) and on the Accounts pages, we update the document title on tab change. Here and a couple other places (Stackscripts Account vs Community), we don't update on tab change. I think it's likely an oversight where it is missing.

Screen.Recording.2024-12-10.at.3.23.54.PM.mov

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing465 Passing2 Skipped109m 15s

Details

Failing Tests
SpecTest
smoke-billing-activity.spec.tsBilling Activity Feed » displays correct timezone for invoice and payment dates

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/billing/smoke-billing-activity.spec.ts"

@harsh-akamai harsh-akamai requested a review from mjac0bs December 12, 2024 10:21
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the latest updates. Thanks @hasyed-akamai!

@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Dec 12, 2024
@hasyed-akamai hasyed-akamai merged commit b2473e6 into linode:develop Dec 18, 2024
22 of 23 checks passed
Copy link

cypress bot commented Dec 18, 2024

Cloud Manager E2E    Run #6990

Run Properties:  status check failed Failed #6990  •  git commit b2473e6649: fix: [M3-8905] - Change document title from address to appropriate keyword (#113...
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #6990
Run duration 26m 16s
Commit git commit b2473e6649: fix: [M3-8905] - Change document title from address to appropriate keyword (#113...
Committer hasyed-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 468
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/core/linodes/linode-config.spec.ts • 1 failed test

View Output Video

Test Artifacts
Linode Config management > End-to-End > Clones a config Screenshots Video

dmcintyr-akamai pushed a commit to dmcintyr-akamai/manager that referenced this pull request Jan 9, 2025
…yword (linode#11385)

* fix: [M3-8905] - Change document title from address to appropriate keyword

* Added changeset: Document title from URL to appropriate keyword

* Make Document title more descriptive

* resolve small regression

* Change some more document title from address to appropriate keyword
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants