-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-8905] - Change document title from address to appropriate keyword #11385
fix: [M3-8905] - Change document title from address to appropriate keyword #11385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it would be better if we could display the feature along with the bucket/stackscript label. For ex: obj-bucket-label | Bucket | Akamai Cloud Manager
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Confirmed that empty state Domains Landing, OBJ Bucket Detail, and StackScripts Detail were showing correct keywords.
I also clicked around the app to see if I could find any other places where this was an issue. I did find a few more inconsistencies.
-
Billing invoice details pages (e.g. https://cloud.linode.com/account/billing/invoices/28083993) - Let's definitely fix this. Can we make it
Invoice | Account & Billing
?
-
Kubernetes cluster details pages - This would be ideal to fix because the cluster name comes after the "Kubernetes Cluster", which is different from how we identify entities on all other pages. We should have
<cluster-label> | Kubernetes Cluster
.
-
Databases details pages - I'm not quite what's best for these pages, to be honest. On the Linode details page (e.g.
<linode label> - Storage
) and on the Accounts pages, we update the document title on tab change. Here and a couple other places (Stackscripts Account vs Community), we don't update on tab change. I think it's likely an oversight where it is missing.
Screen.Recording.2024-12-10.at.3.23.54.PM.mov
Cloud Manager UI test results🔺 1 failing test on test run #5 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/billing/smoke-billing-activity.spec.ts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the latest updates. Thanks @hasyed-akamai!
Cloud Manager E2E Run #6990
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Failed #6990
|
Run duration | 26m 16s |
Commit |
b2473e6649: fix: [M3-8905] - Change document title from address to appropriate keyword (#113...
|
Committer | hasyed-akamai |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
1
|
Flaky |
0
|
Pending |
2
|
Skipped |
0
|
Passing |
468
|
View all changes introduced in this branch ↗︎ |
Tests for review
cypress/e2e/core/linodes/linode-config.spec.ts • 1 failed test
Test | Artifacts | |
---|---|---|
Linode Config management > End-to-End > Clones a config |
Screenshots
Video
|
…yword (linode#11385) * fix: [M3-8905] - Change document title from address to appropriate keyword * Added changeset: Document title from URL to appropriate keyword * Make Document title more descriptive * resolve small regression * Change some more document title from address to appropriate keyword
Description 📝
This PR fixes the issue where the page title on certain landing pages (e.g., Domain Landing, Object Storage Detail pages, and StackScripts details pages) was incorrectly set to the page's URL instead of displaying the expected title with relevant keywords
Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
N/A
Preview 📷
How to test 🧪
Prerequisites
Reproduction steps
Verification steps
As an Author I have considered 🤔
Check all that apply