tech-story: [M3-9017] - Add MSW crud domains #11428
Conversation
abailly-akamai
requested review from
hkhalil-akamai and
pmakode-akamai
and removed request for
a team
| been <strong>added</strong> to <EventLink event={e} to="entity" />. | ||
| </> | ||
| ); | ||
| }, |
There was a problem hiding this comment.
This fixes the case where there is no message associated with a DomainRecord added via importing a zone (most likely an APIv4 omission)
There was a problem hiding this comment.
I noticed this issue for TXT records, since the hostname or value fields are not required. Not sure if this was intended, but could this be fixed as well?
| @@ -28,7 +28,7 @@ const delay = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms)); | |||
| export const queueEvents = (props: QueuedEvents): Promise<void> => { | |||
| const { event, mockState, sequence } = props; | |||
|
|
|||
| const initialDelay = 7500; | |||
| const initialDelay = 2500; | |||
There was a problem hiding this comment.
queuing events quicker since we shouldn't have to wait that much when mocking
|
Re-converting to draft in order to revisit the bugs mentioned in code review |
abailly-akamai
force-pushed
the
M3-9017
branch
from
9334909 to
a9644bb
Compare
|
@jaalah-akamai had a bad update to the loader. all fixed now. changes are limited to just domains without further optimization to the MSW tooling |
| been <strong>added</strong> to <EventLink event={e} to="entity" />. | ||
| </> | ||
| ); | ||
| }, |
There was a problem hiding this comment.
I noticed this issue for TXT records, since the hostname or value fields are not required. Not sure if this was intended, but could this be fixed as well?
There was a problem hiding this comment.
✅ Create, read, update, delete domain records works as expected.
✅ Events appear as expected.
Nice work @abailly-akamai. Should we make a ticket for domain records CRUD?
bnussman-akamai
added
Approved
abailly-akamai
force-pushed
the
M3-9017
branch
from
4686971 to
4d2ae90
Compare
|
Coverage Report: ❌ |
abailly-akamai
force-pushed
the
M3-9017
branch
from
4d2ae90 to
df4ae51
Compare
Cloud Manager UI test results🎉 478 passing tests on test run #6 ↗︎
|
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 30m 53s |
| Commit |
|
| Committer | Alban Bailly |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
478
|
| View all changes introduced in this branch ↗︎ | |
* add MSW crud domains * Added changeset: Add MSW crud domains * feedback @jaalah-akamai * feebback @pmakode-akamai
Description 📝
Straight forward PR to add domains to CRUD mode (including seeds)
Changes 🔄
domainsCRUD modedomainsseedHow to test 🧪
Prerequisites
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅