deps: [M3-8782] - Patch cookie version #11434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaalah-akamai
added
Dependencies
jaalah-akamai
requested review from
mjac0bs and
bnussman-akamai
and removed request for
a team
|
Coverage Report: ✅ |
|
Thanks for looking into this one, looks good! Can you run |
mjac0bs
approved these changes
Dec 20, 2024
|
This PR is stale because it has been open 15 days with no activity. Please attend to this PR or it will be closed in 5 days |
|
@bnussman-akamai done ✅ |
bnussman-akamai
added
Approved
Cloud Manager UI test results🔺 1 failing test on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/kubernetes/lke-update.spec.ts" |
|||||||||||||||||
This was referenced Jan 8, 2025
dmcintyr-akamai
pushed a commit
to dmcintyr-akamai/manager
that referenced
this pull request
Jan 9, 2025
* deps: [M3-8782] - Patch cookie version * Added changeset: Patch `cookie` version as resolution for dependabot * Add lockfile --------- Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
See: https://github.com/linode/manager/security/dependabot/131
cookieis being used bymsw(Mock Service Worker) through@bundled-es-modulescookieis also being used byexpresswhich stems from@storybook/react-viteand@storybook/builder-viteChanges 🔄
Target release date 🗓️
01/14/2025
How to test 🧪
Reproduction steps
yarn why cookieto observe dependencies and versions found in yarn.lockVerification steps
yarn storybookand observe it still worksHoisted just means that it was moved up in the dependency tree for deduplication
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅