-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip - VolumeCreate micro-frontend PoC #11439
Draft
hkhalil-akamai
wants to merge
17
commits into
linode:develop
Choose a base branch
from
hkhalil-akamai:volume-create-poc
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+4,392
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloud Manager UI test results🎉 469 passing tests on test run #4 ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Package the VolumeCreate page as a separate MFC and import into CM using module federation for demonstration purposes.
Note
This PR is a WIP. Changes are throw-away and not meant to represent production-ready code. This is for demonstration purposes only.
Remaining Issues
shareStrategy: "loaded-first"
gives precedence to the module loaded by the host app firstLandingHeader
component causing mysterious "Invariant Failed" errorreact-router-dom
and@tanstack/react-router
to theshared
array.RegionSelect
not to display flags since it relies on theflag-icons
stylesheet.vite-plugin-css-injected-by-js
vite build --watch
which will listen for changes and rebuild the bundle. Note that HMR is not supported.How to run▶️
Commands to build and serve the Volume Create MFE on port 3001 have been added to the
yarn up
command. Simply run it from the repo root and navigate to localhost:3000/volumes/create to see the MFE in action!