Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip - VolumeCreate micro-frontend PoC #11439

Draft
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

hkhalil-akamai
Copy link
Contributor

@hkhalil-akamai hkhalil-akamai commented Dec 18, 2024

Description 📝

Package the VolumeCreate page as a separate MFC and import into CM using module federation for demonstration purposes.

MFE drawio

Note

This PR is a WIP. Changes are throw-away and not meant to represent production-ready code. This is for demonstration purposes only.

Remaining Issues

  • Bearer token not being attached -- API requests unauthorized
    • Fix: shareStrategy: "loaded-first" gives precedence to the module loaded by the host app first
  • LandingHeader component causing mysterious "Invariant Failed" error
    • Fix: add react-router-dom and @tanstack/react-router to the shared array.
  • TypeScript error -- cannot find module 'volume_create'
    • Fix: Typescript module declaration
  • Stylesheets not loading
    • E.g., this caused the RegionSelect not to display flags since it relies on the flag-icons stylesheet.
    • Fix: vite-plugin-css-injected-by-js
  • No dev server support
    • Workaround: using vite build --watch which will listen for changes and rebuild the bundle. Note that HMR is not supported.

How to run ▶️

Commands to build and serve the Volume Create MFE on port 3001 have been added to the yarn up command. Simply run it from the repo root and navigate to localhost:3000/volumes/create to see the MFE in action!

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 469 passing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing469 Passing2 Skipped94m 35s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants