refactor: [M3-6910] - Replace instances in : Object Storage #11456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh-akamai
requested review from
hana-akamai and
abailly-akamai
and removed request for
a team
hana-akamai
approved these changes
Jan 7, 2025
bnussman-akamai
requested changes
Jan 7, 2025
packages/manager/src/features/ObjectStorage/BucketDetail/AccessSelect.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/ObjectStorage/BucketDetail/ObjectDetailsDrawer.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/ObjectStorage/BucketLanding/ClusterSelect.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/ObjectStorage/BucketLanding/CreateBucketDrawer.test.tsx
Outdated
Show resolved
Hide resolved
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Jan 7, 2025
Cloud Manager UI test results🎉 469 passing tests on test run #4 ↗︎
|
Cloud Manager E2E
|
||||||||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 28m 58s |
| Commit |
|
| Committer | hasyed-akamai |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
477
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/core/linodes/clone-linode.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| clone linode > can clone a Linode from Linode details page |
Screenshots
Video
|
|
This was referenced Jan 8, 2025
dmcintyr-akamai
pushed a commit
to dmcintyr-akamai/manager
that referenced
this pull request
Jan 9, 2025
…1456) * refactor: [M3-6910] - Replace instances in : Object Storage * Added changeset: Replace Select with Autocomplete component in Object Storage * Remove unnecessary `vi.mocks`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
We want to get rid of our dependency on react-select for accessibility reasons and to consolidate our usage of third-party libraries.
Changes 🔄
Selectwith Autocomplete inObject Storagecomponent.Target release date 🗓️
N/A
How to test 🧪
Verification steps
(How to verify changes)
Autocomplete.As an Author I have considered 🤔
Check all that apply