Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [DI-22596] - Changes for adding overview section in the alert details page in Cloud Pulse. #11466

Merged

Conversation

venkymano-akamai
Copy link
Contributor

@venkymano-akamai venkymano-akamai commented Dec 31, 2024

Description 📝

Changes for adding overview section in the alert details page in Cloud Pulse.

Changes 🔄

  1. Add new AlertDetailOverview component and its respective changes.
  2. Add new AlertDetailRow component that will be used in different sections in alert details page

Target release date 🗓️

07-01-2024

Preview 📷

Include a screenshot or screen recording of the change.

🔒 Use the Mask Sensitive Data setting for security.

💡 Use <video src="" /> tag when including recordings in table.

Before After
Screenshot 2024-12-31 at 3 32 17 PM Screenshot 2024-12-31 at 3 32 36 PM
Screenshot 2024-12-31 at 3 33 49 PM Screenshot 2024-12-31 at 3 34 35 PM
Screenshot 2024-12-31 at 3 35 24 PM

How to test 🧪

  1. Login as legacy mock user as some endpoints related to alerting not available on production
  2. Navigate to monitor tab.
  3. Navigate to alerts sub tab.
  4. On any alerts click on show details action menu.
  5. You should be able to see the details page with overview section

Figma - https://www.figma.com/design/DoGpj6YJ8cHGqSHQIcSTrI/System-Alerts?node-id=1609-109092&t=C78AUJaAMFpLht1u-0

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@venkymano-akamai
Copy link
Contributor Author

This is still inprogress, will make it ready for review once everything is done

@venkymano-akamai venkymano-akamai changed the title upcoming: [DI-22596] - Overview changes upcoming: [DI-22596] - Changes for adding overview section in the alert details page in Cloud Pulse. Dec 31, 2024
@venkymano-akamai venkymano-akamai marked this pull request as ready for review December 31, 2024 13:30
@venkymano-akamai venkymano-akamai requested a review from a team as a code owner December 31, 2024 13:30
@venkymano-akamai venkymano-akamai requested review from coliu-akamai and harsh-akamai and removed request for a team December 31, 2024 13:30
@ankita-akamai ankita-akamai self-requested a review January 2, 2025 11:12
Copy link

github-actions bot commented Jan 2, 2025

Coverage Report:
Base Coverage: 86.97%
Current Coverage: 86.95%

@venkymano-akamai
Copy link
Contributor Author

@jaalah-akamai / @coliu-akamai ,
Thanks for the suggestion,
The UX doesn't provide us with a figma for dark mode, so we have used colors what was best suiting for us and got it tested. But the suggested colors also works for us and it is more or less similar, added those.

@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label Jan 3, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 469 passing tests on test run #19 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing469 Passing2 Skipped93m 12s

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes!
✅ confirmed overview section appears as expected

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 3, 2025
@jaalah-akamai jaalah-akamai merged commit 53d2633 into linode:develop Jan 3, 2025
23 checks passed
Copy link

cypress bot commented Jan 3, 2025

Cloud Manager E2E    Run #7034

Run Properties:  status check passed Passed #7034  •  git commit 53d2633a1e: upcoming: [DI-22596] - Changes for adding overview section in the alert details ...
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #7034
Run duration 28m 22s
Commit git commit 53d2633a1e: upcoming: [DI-22596] - Changes for adding overview section in the alert details ...
Committer venkatmano-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 471
View all changes introduced in this branch ↗︎

dmcintyr-akamai pushed a commit to dmcintyr-akamai/manager that referenced this pull request Jan 9, 2025
…rt details page in Cloud Pulse. (linode#11466)

* upcoming: [DI-22596] - Overview changes

* upcoming: [DI-22131] - CSS and factory updates for alert detail overview

* upcoming: [DI-22131] - Code clean up and refactoring

* upcoming: [DI-22131] - Type updates and es lint fixes

* upcoming: [DI-22131] - Add more UT's

* upcoming: [DI-22131] - Add changeset

* upcoming: [DI-22131] - Code reusability

* upcoming: [DI-22131] - Code refactoring, comments update

* upcoming: [DI-22131] - Code refactoring, todo comments update

* upcoming: [DI-22131] - Code refactoring

* upcoming: [DI-22131] - Code refactoring

* upcoming: [DI-22131] - Code refactoring

* upcoming: [DI-22131] - Edit Changeset

* upcoming: [DI-22131] - Typography font updates

* upcoming: [DI-22131] - Util function test optimisation

* upcoming: [DI-22131] - Code clean up and refactoring

* upcoming: [DI-22131] - Code clean up and refactoring

* upcoming: [DI-22131] - Code clean up and refactoring

* upcoming: [DI-22131] - Use imports from linode UI

* upcoming: [DI-22131] - Update UT's

* upcoming: [DI-22131] - Comment updates

* upcoming: [DI-22131] - Comment updates

* upcoming: [DI-22131] - Rename service type to service type list

* upcoming: [DI-22131] - Use shared mock data

* upcoming: [DI-22131] - Changed text and background color

---------

Co-authored-by: vmangalr <vmangalr@akamai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Cloud Pulse - Alerting Cloud Pulse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants