-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [DI-22596] - Changes for adding overview section in the alert details page in Cloud Pulse. #11466
upcoming: [DI-22596] - Changes for adding overview section in the alert details page in Cloud Pulse. #11466
Conversation
This is still inprogress, will make it ready for review once everything is done |
Coverage Report: ❌ |
packages/manager/src/features/CloudPulse/Alerts/AlertsDetail/AlertDetailRow.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Alerts/AlertsDetail/AlertDetailRow.tsx
Outdated
Show resolved
Hide resolved
@jaalah-akamai / @coliu-akamai , |
Cloud Manager UI test results🎉 469 passing tests on test run #19 ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the changes!
✅ confirmed overview section appears as expected
Cloud Manager E2E Run #7034
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Passed #7034
|
Run duration | 28m 22s |
Commit |
53d2633a1e: upcoming: [DI-22596] - Changes for adding overview section in the alert details ...
|
Committer | venkatmano-akamai |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
2
|
Skipped |
0
|
Passing |
471
|
View all changes introduced in this branch ↗︎ |
…rt details page in Cloud Pulse. (linode#11466) * upcoming: [DI-22596] - Overview changes * upcoming: [DI-22131] - CSS and factory updates for alert detail overview * upcoming: [DI-22131] - Code clean up and refactoring * upcoming: [DI-22131] - Type updates and es lint fixes * upcoming: [DI-22131] - Add more UT's * upcoming: [DI-22131] - Add changeset * upcoming: [DI-22131] - Code reusability * upcoming: [DI-22131] - Code refactoring, comments update * upcoming: [DI-22131] - Code refactoring, todo comments update * upcoming: [DI-22131] - Code refactoring * upcoming: [DI-22131] - Code refactoring * upcoming: [DI-22131] - Code refactoring * upcoming: [DI-22131] - Edit Changeset * upcoming: [DI-22131] - Typography font updates * upcoming: [DI-22131] - Util function test optimisation * upcoming: [DI-22131] - Code clean up and refactoring * upcoming: [DI-22131] - Code clean up and refactoring * upcoming: [DI-22131] - Code clean up and refactoring * upcoming: [DI-22131] - Use imports from linode UI * upcoming: [DI-22131] - Update UT's * upcoming: [DI-22131] - Comment updates * upcoming: [DI-22131] - Comment updates * upcoming: [DI-22131] - Rename service type to service type list * upcoming: [DI-22131] - Use shared mock data * upcoming: [DI-22131] - Changed text and background color --------- Co-authored-by: vmangalr <vmangalr@akamai.com>
Description 📝
Changes for adding overview section in the alert details page in Cloud Pulse.
Changes 🔄
Target release date 🗓️
07-01-2024
Preview 📷
Include a screenshot or screen recording of the change.
🔒 Use the Mask Sensitive Data setting for security.
💡 Use
<video src="" />
tag when including recordings in table.How to test 🧪
Figma - https://www.figma.com/design/DoGpj6YJ8cHGqSHQIcSTrI/System-Alerts?node-id=1609-109092&t=C78AUJaAMFpLht1u-0
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅