fix: [M3-9025] - Region validation when switching to LKE-E #11471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hana-akamai
requested review from
carrillo-erik,
pmakode-akamai and
mjac0bs
and removed request for
a team
bnussman-akamai
approved these changes
Jan 6, 2025
packages/manager/src/features/Kubernetes/CreateCluster/CreateCluster.tsx
Outdated
Show resolved
Hide resolved
mjac0bs
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Resetting the region looks good!
I don't know how nitpicky we want to get about the checkout message - I did notice that it will say to 'select a region and add a node pool' when a node pool has already been added, and the valid region is the only thing needed. Since it does disappear as soon as the region is selected and the CTA is correctly enabled, I don't really think this will cause much confusion and it could be okay as is.
Screen.Recording.2025-01-06.at.10.30.15.AM.mov
|
Coverage Report: ❌ |
Cloud Manager UI test results🎉 469 passing tests on test run #2 ↗︎
|
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 29m 55s |
| Commit |
|
| Committer | Hana Xu |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
471
|
| View all changes introduced in this branch ↗︎ | |
dmcintyr-akamai
pushed a commit
to dmcintyr-akamai/manager
that referenced
this pull request
Jan 9, 2025
) ## Description 📝 Fix region validation when a user is switching from LKE to LKE-E tier in the Kubernetes create flow ## How to test 🧪 ### Prerequisites (How to setup test environment) - Ensure you have the customer tags for LKE-E (check project tracker) ### Reproduction steps (How to reproduce the issue, if applicable) - [ ] Go to another branch or dev environment and navigate to the Kubernetes create page - [ ] Enter a cluster label, select LKE as the tier, select a non LKE-E supported region (i.e. Atlanta, GA), select a HA control plane option, add a plan - [ ] Change the selected tier to LKE-E. Notice the region select is cleared but the Create Cluster button is enabled. Clicking Create Cluster shows an error text in the Region field ### Verification steps (How to verify changes) - [ ] Checkout this branch or PR preview link and navigate to the Kubernetes create page - [ ] Enter a cluster label, select LKE as the tier, select a non LKE-E supported region (i.e. Atlanta, GA), select a HA control plane option, add a plan - [ ] Change the selected tier to LKE-E. The region select should be cleared and the Create Cluster button is disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Fix region validation when a user is switching from LKE to LKE-E tier in the Kubernetes create flow
Preview 📷
Screen.Recording.2025-01-03.at.11.37.48.AM.mov
Screen.Recording.2025-01-03.at.11.39.19.AM.mov
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅