Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-9060] - Object Storage endpoint_type sorting #11472

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

jaalah-akamai
Copy link
Contributor

Description πŸ“

The property name for endpoint_type was misspelled causing the sorting for that column not to work.

Target release date πŸ—“οΈ

01/14/2025

How to test πŸ§ͺ

Verification steps

  • Go to /object-storage/buckets
  • Ensure feature flag is enabled
  • Ensure you have the customer tags
    • obj_use_regions_mode
    • obj_enable_use_endpoint_types
  • Observe that Endpoint Type sorting now works
Author Checklists

As an Author, to speed up the review process, I considered πŸ€”

πŸ‘€ Doing a self review
❔ Our contribution guidelines
🀏 Splitting feature into small PRs
βž• Adding a changeset
πŸ§ͺ Providing/improving test coverage
πŸ” Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
πŸ‘£ Providing comprehensive reproduction steps
πŸ“‘ Providing or updating our documentation
πŸ•› Scheduling a pair reviewing session
πŸ“± Providing mobile support
β™Ώ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed βœ…

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@jaalah-akamai jaalah-akamai added Bug Fixes for regressions or bugs Object Storage Gen2 labels Jan 3, 2025
@jaalah-akamai jaalah-akamai self-assigned this Jan 3, 2025
@jaalah-akamai jaalah-akamai requested a review from a team as a code owner January 3, 2025 16:56
@jaalah-akamai jaalah-akamai requested review from bnussman-akamai and cpathipa and removed request for a team January 3, 2025 16:56
Copy link

github-actions bot commented Jan 3, 2025

Coverage Report: βœ…
Base Coverage: 86.95%
Current Coverage: 86.95%

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Jaalah - confirmed sorting via endpoint types now works πŸŽ‰

does this need a changeset?

@coliu-akamai coliu-akamai added the Approved Multiple approvals and ready to merge! label Jan 3, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

πŸ”Ί 2 failing tests on test run #2 β†—οΈŽ

❌ Failingβœ… Passingβ†ͺ️ SkippedπŸ• Duration
2 Failing469 Passing2 Skipped100m 44s

Details

Failing Tests
SpecTest
❌lke-create.spec.tsLKE Cluster Creation » can create an LKE cluster
❌lke-create.spec.tsLKE Cluster Creation with APL enabled » can create an LKE cluster with APL flag enabled

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/kubernetes/lke-create.spec.ts,cypress/e2e/core/kubernetes/lke-create.spec.ts"

@jaalah-akamai jaalah-akamai merged commit 5787534 into linode:develop Jan 7, 2025
21 of 23 checks passed
Copy link

cypress bot commented Jan 7, 2025

Cloud Manager E2EΒ  Β  Run #7048

Run Properties:Β  status check failedΒ FailedΒ #7048 Β β€’Β  git commit 5787534ba5: fix: [M3-9060] - Object Storage `endpoint_type` sorting (#11472)
Project Cloud Manager E2E
Branch Review develop
Run status status check failedΒ FailedΒ #7048
Run duration 27m 54s
Commit git commit 5787534ba5: fix: [M3-9060] - Object Storage `endpoint_type` sorting (#11472)
Committer Jaalah Ramos
View all properties for this run β†—οΈŽ

Test results
Tests that failedΒ  Failures 11
Tests that were flakyΒ  Flaky 2
Tests that did not run due to a developer annotating a test with .skipΒ  Pending 2
Tests that did not run due to a failure in a mocha hookΒ  Skipped 0
Tests that passedΒ  Passing 467
View all changes introduced in this branch β†—οΈŽ

Tests for review

FailedΒ  linodes/smoke-delete-linode.spec.ts β€’ 4 failed tests

View Output Video

Test Artifacts
delete linode > deletes linode from linode details page Screenshots Video
delete linode > deletes linode from setting tab in linode details page Screenshots Video
delete linode > deletes linode from linode landing page Screenshots Video
delete linode > deleting multiple linodes with action menu Screenshots Video
FailedΒ  firewalls/migrate-linode-with-firewall.spec.ts β€’ 1 failed test

View Output Video

Test Artifacts
Migrate Linode With Firewall > migrates linode with firewall - real data Screenshots Video
FailedΒ  images/search-images.spec.ts β€’ 1 failed test

View Output Video

Test Artifacts
Search Images > creates two images and make sure they show up in the table and are searchable Screenshots Video
FailedΒ  volumes/create-volume.spec.ts β€’ 4 failed tests

View Output Video

Test Artifacts
volume create flow > creates an attached volume Screenshots Video
volume create flow > displays a warning notice on Volume Create page re: rebooting for client library updates under the appropriate conditions Screenshots Video
volume create flow > displays a warning notice re: rebooting for client library updates under the appropriate conditions in Create/Attach Volume drawer Screenshots Video
volume create flow > creates a volume from an existing Linode Screenshots Video
FailedΒ  volumes/attach-volume.spec.ts β€’ 1 failed test

View Output Video

Test Artifacts
volume attach and detach flows > attaches a volume to a Linode Screenshots Video
FlakinessΒ  linode-config.spec.ts β€’ 1 flaky test

View Output Video

Test Artifacts
Linode Config management > End-to-End > Clones a config Screenshots Video
FlakinessΒ  search-linodes.spec.ts β€’ 1 flaky test

View Output Video

Test Artifacts
Search Linodes > create a linode and make sure it shows up in the table and is searchable in main search tool Screenshots Video

dmcintyr-akamai pushed a commit to dmcintyr-akamai/manager that referenced this pull request Jan 9, 2025
* fix: [M3-9060] - Object Storage  sorting

* Add changeset

---------

Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs Object Storage Gen2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants