-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-9060] - Object Storage endpoint_type
sorting
#11472
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaalah-akamai
requested review from
bnussman-akamai and
cpathipa
and removed request for
a team
January 3, 2025 16:56
bnussman-akamai
approved these changes
Jan 3, 2025
Coverage Report: β
|
coliu-akamai
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Jaalah - confirmed sorting via endpoint types now works π
does this need a changeset?
Cloud Manager UI test resultsπΊ 2 failing tests on test run #2 βοΈ
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/kubernetes/lke-create.spec.ts,cypress/e2e/core/kubernetes/lke-create.spec.ts" |
cpathipa
approved these changes
Jan 6, 2025
This was referenced Jan 8, 2025
dmcintyr-akamai
pushed a commit
to dmcintyr-akamai/manager
that referenced
this pull request
Jan 9, 2025
* fix: [M3-9060] - Object Storage sorting * Add changeset --------- Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved
Multiple approvals and ready to merge!
Bug
Fixes for regressions or bugs
Object Storage Gen2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description π
The property name for
endpoint_type
was misspelled causing the sorting for that column not to work.Target release date ποΈ
01/14/2025
How to test π§ͺ
Verification steps
/object-storage/buckets
obj_use_regions_mode
obj_enable_use_endpoint_types
Author Checklists
As an Author, to speed up the review process, I considered π€
π Doing a self review
β Our contribution guidelines
π€ Splitting feature into small PRs
β Adding a changeset
π§ͺ Providing/improving test coverage
π Removing all sensitive information from the code and PR description
π© Using a feature flag to protect the release
π£ Providing comprehensive reproduction steps
π Providing or updating our documentation
π Scheduling a pair reviewing session
π± Providing mobile support
βΏ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed β