-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-9024] - Mask sensitive data in Managed and Longview #11476
Merged
mjac0bs
merged 13 commits into
linode:develop
from
mjac0bs:M3-9024-mask-sensitive-data-in-managed-and-longview
Jan 7, 2025
Merged
fix: [M3-9024] - Mask sensitive data in Managed and Longview #11476
mjac0bs
merged 13 commits into
linode:develop
from
mjac0bs:M3-9024-mask-sensitive-data-in-managed-and-longview
Jan 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjac0bs
force-pushed
the
M3-9024-mask-sensitive-data-in-managed-and-longview
branch
from
January 7, 2025 15:14
8db8f0c
to
878e9fb
Compare
mjac0bs
requested review from
cpathipa and
harsh-akamai
and removed request for
a team
January 7, 2025 15:14
… with Mask Sensitive Data setting enabled
Cloud Manager UI test results🎉 474 passing tests on test run #2 ↗︎
|
Coverage Report: ❌ |
bnussman-akamai
approved these changes
Jan 7, 2025
cpathipa
approved these changes
Jan 7, 2025
This was referenced Jan 8, 2025
dmcintyr-akamai
pushed a commit
to dmcintyr-akamai/manager
that referenced
this pull request
Jan 9, 2025
…11476) * Add maskable text to Managed Contacts * Update the docs link URL to a more helpful doc * Make component for reusable copy * Use component in Billing Contact Info and SSH Access Pub Key * Make MaskableText icon styling more flexible; add to Longview command * Add masking to Longview API Key * Clean up styles * Mask IP in Longview * Mask IP Address on SSH Access Managed tab * Fix margin for API Key * Fix spacing for Longview API key * Mask user in Managed and Longview * Added changeset: Visibility of sensitive data in Managed and Longview with Mask Sensitive Data setting enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
We overlooked a couple of older, more niche sections of Cloud Manager with the Mask Sensitive Data feature. This PR masks data in Managed and Longview.
Changes 🔄
Target release date 🗓️
1/14/25
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅