fix: [M3-9063] - Display Kubernetes API endpoint for LKE-E cluster #11485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hana-akamai
requested review from
bnussman-akamai,
hkhalil-akamai and
mjac0bs
and removed request for
a team
mjac0bs
approved these changes
Jan 7, 2025
hkhalil-akamai
approved these changes
Jan 8, 2025
hkhalil-akamai
added
Approved
|
Coverage Report: ✅ |
Cloud Manager UI test results🎉 478 passing tests on test run #5 ↗︎
|
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 27m 03s |
| Commit |
|
| Committer | Hana Xu |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
478
|
| View all changes introduced in this branch ↗︎ | |
This was referenced Jan 8, 2025
dmcintyr-akamai
pushed a commit
to dmcintyr-akamai/manager
that referenced
this pull request
Jan 9, 2025
…inode#11485) ## Description 📝 Due to the way that existing code was written, we were only returning Kubernetes API endpoints for clusters if the endpoint matched port 443 (e.g. `/linodelke\.net:443`). However, LKE-E endpoints use the `6443` port so nothing was returning This PR adds a check to render the first available endpoint if port 443 is not available ## Changes 🔄 List any change(s) relevant to the reviewer. - Render the first available endpoint if endpoint with port 443 is not available - Added some unit tests ## How to test 🧪 ### Prerequisites (How to setup test environment) - Ensure you have LKE-E customer tags (check project tracker) - Have an LKE-E cluster created ### Reproduction steps (How to reproduce the issue, if applicable) - [ ] On another branch (e.g. `develop`), go to the details page of an LKE-E cluster - [ ] The Kubernetes API endpoint displays `Your endpoint will be displayed here once it is available.` ### Verification steps (How to verify changes) - [ ] Checkout this PR or use the preview link, go to the details page of an LKE-E cluster - [ ] The Kubernetes API endpoint displays the first endpoint available (should be something like `https://lke287706.us-ord.enterprise.linodelke.net:6443`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Due to the way that existing code was written, we were only returning Kubernetes API endpoints for clusters if the endpoint matched port 443 (e.g.
/linodelke\.net:443). However, LKE-E endpoints use the6443port so nothing was returningThis PR adds a check to render the first available endpoint if port 443 is not available
Changes 🔄
List any change(s) relevant to the reviewer.
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
develop), go to the details page of an LKE-E clusterYour endpoint will be displayed here once it is available.Verification steps
(How to verify changes)
https://lke287706.us-ord.enterprise.linodelke.net:6443)Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅