-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-9031] - Replace one-off hardcoded color values with color tokens pt5 #11488
base: develop
Are you sure you want to change the base?
Conversation
Cloud Manager UI test results🔺 24 failing tests on test run #2 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts,cypress/e2e/core/linodes/rescue-linode.spec.ts,cypress/e2e/core/firewalls/update-firewall.spec.ts,cypress/e2e/core/firewalls/update-firewall.spec.ts,cypress/e2e/core/firewalls/update-firewall.spec.ts,cypress/e2e/core/linodes/rebuild-linode.spec.ts,cypress/e2e/core/linodes/rebuild-linode.spec.ts,cypress/e2e/core/linodes/smoke-delete-linode.spec.ts,cypress/e2e/core/linodes/smoke-delete-linode.spec.ts,cypress/e2e/core/linodes/smoke-delete-linode.spec.ts,cypress/e2e/core/linodes/smoke-delete-linode.spec.ts,cypress/e2e/core/stackscripts/create-stackscripts.spec.ts,cypress/e2e/core/firewalls/create-firewall.spec.ts,cypress/e2e/core/linodes/create-linode-region-select.spec.ts,cypress/e2e/core/volumes/create-volume.spec.ts,cypress/e2e/core/volumes/create-volume.spec.ts,cypress/e2e/core/volumes/create-volume.spec.ts,cypress/e2e/core/volumes/create-volume.spec.ts,cypress/e2e/core/firewalls/migrate-linode-with-firewall.spec.ts,cypress/e2e/core/account/service-transfer.spec.ts,cypress/e2e/core/linodes/backup-linode.spec.ts,cypress/e2e/core/linodes/backup-linode.spec.ts,cypress/e2e/core/volumes/attach-volume.spec.ts,cypress/e2e/core/images/search-images.spec.ts" |
@@ -39,7 +39,7 @@ const getFlagClass = (country: Country | string) => { | |||
|
|||
const StyledFlag = styled(Box, { label: 'StyledFlag' })(({ theme }) => ({ | |||
boxShadow: | |||
theme.palette.mode === 'light' ? `0px 0px 0px 1px #00000010` : undefined, | |||
theme.palette.mode === 'light' ? `0px 0px 0px 1px #000000` : undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have a suitable color token that can be used in place of #000000
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dwiley-akamai, we have a global token for black color: theme.tokens.color.Neutrals.Black
with the value #232326
. This is slightly different from #000000
. If this is what we are expecting, we can go ahead and make the replacement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaalah , could you please provide your thoughts on the comment above ? 😊
Description 📝
Note
The new colors are based on design tokens and have been selected to closely match the existing colors.
Changes 🔄
#aaa
withtheme.tokens.color.Neutrals[50]
#a3a3ab
#243142
withttheme.tokens.color.Brand[100]
#00314d
gray
withtheme.tokens.color.Neutrals[60]
#83838c
#6e6e6e
withtheme.tokens.color.Neutrals[70]
#696970
#979797
withtheme.tokens.color.Neutrals[60]
#83838c
#3683dc
withtheme.tokens.color.Ultramarine[80]
#3a5ccc
blue
withtheme.graphs.blue
darkGreen
withtheme.graphs.darkGreen
lightGreen
withtheme.graphs.lightGreen
purple
withtheme.graphs.purple
yellow
withtheme.graphs.yellow
red
withtheme.graphs.red
Target release date 🗓️
N/A
Preview 📷
How to test 🧪
As an Author I have considered 🤔
Check all that apply