Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-9009] - Fix spacing for LKE cluster tags #11507

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented Jan 10, 2025

Description 📝

This PR fixes an existing LKE bug. On the LKE cluster details page, when the user has more than one tag, the tags get cut off on the left side in desktop view. Full tags are shown in tablet and mobile views.

Changes 🔄

  • Adjusted the grid column layout at the large screen size
  • Set the left margin on the tags grid item to retain correct alignment

Target release date 🗓️

1/28/25

Preview 📷

Before After
Screenshot 2025-01-10 at 10 21 28 AM Screenshot 2025-01-10 at 10 13 31 AM
Screen.Recording.2025-01-10.at.10.20.48.AM.mov
Screen.Recording.2025-01-10.at.10.14.01.AM.mov

How to test 🧪

Prerequisites

(How to setup test environment)

  • Have an LKE cluster on your account with 2+ cluster tags

Reproduction steps

(How to reproduce the issue, if applicable)

  • On another branch (prod or develop), navigate to the LKE cluster details page and note that, at desktop screen sizes, only most of the first tag is displayed.

Verification steps

(How to verify changes)

  • On this branch, navigate to the LKE cluster details page and note that for 2+ cluster tags in desktop view, tags display as expected on the lefthand side and are styled as expected (gradient) on the right hand side.
  • Resize the screen and confirm tags display as expected at other screen sizes.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mjac0bs mjac0bs added Bug Fixes for regressions or bugs LKE Related to Linode Kubernetes Engine offerings labels Jan 10, 2025
@mjac0bs mjac0bs self-assigned this Jan 10, 2025
@mjac0bs mjac0bs requested a review from a team as a code owner January 10, 2025 18:30
@mjac0bs mjac0bs requested review from carrillo-erik and hkhalil-akamai and removed request for a team January 10, 2025 18:30
Copy link

Coverage Report:
Base Coverage: 87.19%
Current Coverage: 87.19%

@hana-akamai hana-akamai added the Add'tl Approval Needed Waiting on another approval! label Jan 10, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 474 passing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing474 Passing2 Skipped85m 26s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add'tl Approval Needed Waiting on another approval! Bug Fixes for regressions or bugs LKE Related to Linode Kubernetes Engine offerings Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants