Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-6919] - replace remaining react-select instances & types in Linodes Feature #11509

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Jan 10, 2025

Description 📝

Continuing the replacement of react-select through the app. This one targets left over instances & borrowed types in Linode detail

Changes 🔄

  • replace old IP sharing select
  • replace old Linode settings disk select in password panel
  • delete unused DiskSelect component
  • small modifications in Select component
  • export new AutocompleteOption types to replace the old Item

Preview 📷

No visual or functional regression to expect from this PR

How to test 🧪

Verification steps

  • Verify IP sharing select behavior: /linodes/{id}/networking > IP Sharing
  • Verify Disk select in Linode Settings password panel: /linodes/{id}/settings
  • Confirm tests & types
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@abailly-akamai abailly-akamai marked this pull request as ready for review January 10, 2025 21:49
@abailly-akamai abailly-akamai requested review from a team as code owners January 10, 2025 21:49
@abailly-akamai abailly-akamai requested review from jdamore-linode, dwiley-akamai and coliu-akamai and removed request for a team January 10, 2025 21:49
onChange={(e, value) => handleChartRangeChange(value)}
options={options}
sx={{ mt: 1, width: 150 }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing changed here, just linting - only change is above

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 474 passing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing474 Passing2 Skipped98m 42s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants