upcoming: [M3-9141] - Add udp_check_port support to NodeBalancers
#11534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
hana-akamai and
cpathipa
and removed request for
a team
bnussman-akamai
changed the title
udp_check_port to NodeBalancersudp_check_port support to NodeBalancers
|
Coverage Report: ✅ |
bnussman-akamai
requested review from
jdamore-linode
and removed request for
a team
hana-akamai
reviewed
Jan 21, 2025
packages/manager/cypress/e2e/core/nodebalancers/smoke-create-nodebal.spec.ts
Outdated
Show resolved
Hide resolved
|
@hana-akamai I honestly don't know how to do that with MUI grid. Does this look any better?
|
|
@bnussman hmm looks a bit too cramped with 3 side by side, I guess we can keep it as is I'm getting an error when trying to save the UDP changes, is this expected?
|
|
@hana-akamai I wasn't able to replicate that. You'll need the |
hana-akamai
approved these changes
Jan 23, 2025
cpathipa
approved these changes
Jan 24, 2025
Cloud Manager UI test results🔺 1 failing test on test run #17 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts" |
|||||||||||||||||
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 30m 22s |
| Commit |
|
| Committer | Banks Nussman |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
482
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
udp_check_portNodeBalancer config field ➕tcpprotocol is selected 🚫Preview 📷
How to test 🧪
udpflag is enablednb-udp-alphacustomer tagUDPfor this new field to be visibleAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅