refactor: [M3-7437] - Prepare Profile Queries for React Query v5 #9991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
added
Work in Progress
React Query
bnussman-akamai
requested review from
dwiley-akamai and
tyler-akamai
and removed request for
a team
|
Coverage Report: ✅ |
| @@ -1609,6 +1609,11 @@ | |||
| resolved "https://registry.yarnpkg.com/@bcoe/v8-coverage/-/v8-coverage-0.2.3.tgz#75a2e8b51cb758a7553d6804a5932d7aace75c39" | |||
| integrity sha512-0hYQ8SB4Db5zvZB4axdMHGwEaQjkZzFjQiN9LVYvIFB2nSUHW9tYpxWriPrWDASIxiaXax83REcLxuSdnGPZtw== | |||
|
|
|||
| "@bnussman/query-key@0.0.7": | |||
There was a problem hiding this comment.
Should we create this as a package under the Linode/Akamai org?
There was a problem hiding this comment.
That's the plan! 📦 I will go over this package in the next cafe and we can proceed based on how the cafe discussion goes.
|
Verified:
|
| queryFn: () => getPersonalAccessTokens(params, filter), | ||
| queryKey: [params, filter], | ||
| }), | ||
| profile: { |
There was a problem hiding this comment.
I think this might cause conflicts with my current changes since getProfile now takes an optional header argument.
I think a simple fix would be:
queryFn: getProfile, --> queryFn: () => getProfile(),
But I can even add this in my PR if this is merged before that
|
LGTM 🚀 Its def cleaner and more consistent, great job |
tyler-akamai
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Changes of plans: No feature branch for the React Query update project. We will do all of the required changes first (merging to develop) then bump the React Query version last. This will eliminate the need for a feature branch.
Changes 🔄
Array(required for React Query v4)How to test 🧪
Important
These code changes should result in no changes to the functionality/behavior of Cloud Manager. It is simply a migration to newer patterns.
Verification steps
As an Author I have considered 🤔