-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-7535] β Update OBJ types to support Multicluster changes #9996
Merged
dwiley-akamai
merged 8 commits into
linode:develop
from
dwiley-akamai:M3-7535-obj-types-updates
Jan 4, 2024
Merged
feat: [M3-7535] β Update OBJ types to support Multicluster changes #9996
dwiley-akamai
merged 8 commits into
linode:develop
from
dwiley-akamai:M3-7535-obj-types-updates
Jan 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwiley-akamai
commented
Dec 13, 2023
dwiley-akamai
requested review from
hana-akamai,
tyler-akamai and
cpathipa
and removed request for
a team
December 13, 2023 22:57
Coverage Report: β
|
Verified:
|
cpathipa
reviewed
Dec 19, 2023
hana-akamai
reviewed
Jan 2, 2024
hana-akamai
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving pending merge conflicts are addressed
- The following are populated without app errors/crashing:
- OBJ landing page (Buckets and Access Keys tabs) β
- Bucket Detail drawer β
- Edit Access Key drawer β
- Able to create Buckets β
- Able to create Access Keys β
dwiley-akamai
requested review from
cpathipa
and removed request for
tyler-akamai
January 3, 2024 22:29
cpathipa
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM!
- Verified type changes according to the API spec.
- Able to create Bucket.
- Able to create Accesskey.
cpathipa
added
Approved
Multiple approvals and ready to merge!
and removed
Add'tl Approval Needed
Waiting on another approval!
labels
Jan 4, 2024
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description π
Update OBJ types to support upcoming changes for Multicluster as per API spec (see ticket for more details).
Changes π
regions
property added toObjectStorageKey
ScopeRequest
andScopeObject
that extendScope
regions
property added toObjectStorageKeyRequest
andUpdateObjectStorageKeyRequest
label
made optional forUpdateObjectStorageKeyRequest
region
added toObjectStorageBucketRequestPayload
cluster
made optionalregion
added toObjectStorageBucket
How to test π§ͺ
The main things are confirming the changes match what is prescribed by the API spec and that no functionality has been adversely impacted.
Verification steps
As an Author I have considered π€