Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-7535] – Update OBJ types to support Multicluster changes #9996

Merged

Conversation

dwiley-akamai
Copy link
Contributor

@dwiley-akamai dwiley-akamai commented Dec 12, 2023

Description πŸ“

Update OBJ types to support upcoming changes for Multicluster as per API spec (see ticket for more details).

Changes πŸ”„

  • regions property added to ObjectStorageKey
  • refactor: new ScopeRequest and ScopeObject that extend Scope
  • regions property added to ObjectStorageKeyRequest and UpdateObjectStorageKeyRequest
    • label made optional for UpdateObjectStorageKeyRequest
  • region added to ObjectStorageBucketRequestPayload
    • cluster made optional
  • region added to ObjectStorageBucket

How to test πŸ§ͺ

The main things are confirming the changes match what is prescribed by the API spec and that no functionality has been adversely impacted.

Verification steps

  • The following are populated without app errors/crashing:
    • OBJ landing page (Buckets and Access Keys tabs)
    • Bucket Detail drawer
    • Edit Access Key drawer
  • Able to create Buckets
  • Able to create Access Keys

As an Author I have considered πŸ€”

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@dwiley-akamai dwiley-akamai marked this pull request as ready for review December 13, 2023 22:57
@dwiley-akamai dwiley-akamai requested a review from a team as a code owner December 13, 2023 22:57
@dwiley-akamai dwiley-akamai requested review from hana-akamai, tyler-akamai and cpathipa and removed request for a team December 13, 2023 22:57
Copy link

github-actions bot commented Dec 13, 2023

Coverage Report: βœ…
Base Coverage: 79.16%
Current Coverage: 79.16%

@tyler-akamai
Copy link
Contributor

tyler-akamai commented Dec 17, 2023

Verified:

  • OBJ landing page (Buckets and Access Keys tabs) are populated without app errors/crashing
  • Bucket Detail drawer are populated without app errors/crashing
  • Edit Access Key drawer
  • Able to create Buckets
  • Able to create Access Keys

Copy link
Contributor

@hana-akamai hana-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending merge conflicts are addressed

  • The following are populated without app errors/crashing:
    • OBJ landing page (Buckets and Access Keys tabs) βœ…
    • Bucket Detail drawer βœ…
    • Edit Access Key drawer βœ…
  • Able to create Buckets βœ…
  • Able to create Access Keys βœ…

@hana-akamai hana-akamai added the Add'tl Approval Needed Waiting on another approval! label Jan 3, 2024
@dwiley-akamai dwiley-akamai requested review from cpathipa and removed request for tyler-akamai January 3, 2024 22:29
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

  • Verified type changes according to the API spec.
  • Able to create Bucket.
  • Able to create Accesskey.

@cpathipa cpathipa added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 4, 2024
@dwiley-akamai dwiley-akamai merged commit 5473231 into linode:develop Jan 4, 2024
18 checks passed
@dwiley-akamai dwiley-akamai deleted the M3-7535-obj-types-updates branch January 4, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! OBJ Multi-Cluster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants