Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clock@schorschii] v1.7 - Fixes #1055 #1058

Closed
wants to merge 1 commit into from

Conversation

claudiux
Copy link
Member

@claudiux claudiux commented Feb 15, 2024

@schorschii
Hi Georg,

I've started trying to fix the bug #1055. The work is not finished.

TODO:

  • The label should be displayed as soon as it is modified. (For the time being, this desklet must be restarted to display it.)
  • Match the label color to the clock theme.

I hope I'm going the right way.

Regards
claudiux

@claudiux claudiux marked this pull request as draft February 15, 2024 23:46
@schorschii
Copy link
Contributor

schorschii commented Feb 16, 2024

Hi @claudiux , I appreciate you effort but I have some concerns.

  • Do you think that such an additional label is really necessary? In my opinion, the default cinnamon desklet label is intended for that.
  • The functionality should be consistent over all (of my) desklets. Either we implement such a label in all of my desklets or we add a new setting for this custom label only in the clock desklet, but this may cause more confusion.

In case we decide to implement it:

  • The color must be adjustable because there exists black and white clock faces.
  • For better/exact centering of the text, CSS text-align:center could be used while stretching the label over the entire width like the percentage in my diskspace desklet.

I've started trying to fix the bug #1055.

I'd like to point out that this is not a bug but a feature request.

@claudiux claudiux closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants