Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image not showing in notification when notifications are set to show at bottom of screen. #12623

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions js/ui/messageTray.js
Original file line number Diff line number Diff line change
Expand Up @@ -1009,19 +1009,10 @@ MessageTray.prototype = {
let getBottomPositionY = () => {
return this._monitor.y + this._monitor.height - this._notificationBin.height - bottomGap;
};
let shouldReturn = false;
let initialY = getBottomPositionY();
// For multi-line notifications, the correct height will not be known until the notification is done animating,
// so this will set _notificationBin.y when queue-redraw is emitted, and return early if the height decreases
// to prevent unnecessary property setting.
// so this will set _notificationBin.y when queue-redraw is emitted.
this.bottomPositionSignal = this._notificationBin.connect('queue-redraw', () => {
if (shouldReturn) {
return;
}
this._notificationBin.y = getBottomPositionY();
if (initialY > this._notificationBin.y) {
shouldReturn = true;
}
});
}

Expand Down
Loading