Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of gnome-common build dependency #231

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

Jakko3
Copy link
Contributor

@Jakko3 Jakko3 commented Jan 8, 2024

"gnome-common" is deprecated. Replace the autogen.sh script by the template suggested at the gnome-common migration page [1], adding the mentioned aclocal line.

"gnome-common" is deprecated. Replace the autogen.sh script by the
template suggested at the gnome-common migration page [1], adding
the mentioned aclocal line.

[1] https://wiki.gnome.org/Projects/GnomeCommon/Migration
@Jakko3 Jakko3 force-pushed the slick-greeter_autogen branch from c292a83 to 036182c Compare January 8, 2024 22:26
@mtwebster mtwebster merged commit 52a1b59 into linuxmint:master Feb 12, 2024
@Jakko3
Copy link
Contributor Author

Jakko3 commented Feb 12, 2024

Thanks for merging!

As far as I can see, the test build failed with:

./configure: line 4857: syntax error near unexpected token `0.35.0'
./configure: line 4857: `IT_PROG_INTLTOOL(0.35.0)'

Sorry for causing issues. I did a test build in Alpine Linux and it ran through. When I compare the build logs:

  • in the build log here I see:
    • autoreconf: configure.ac: not using Intltool
  • in the build log on Alpine Linux on the same line there is (I don't know why it's different, probably some setting in the build environment):
    • autoreconf: running: intltoolsize --copy --force

Looking into the gnome-common migration page, likely the "intltoolize" line needs to be added between the "aclocal" and "autoreconf" lines in autogen.sh.

Do you want me to push a new PR to add the "intltoolize" line? Or is it easier if you add the line?

Just as a side note, the folloing page "Migrating from Intltool to Gettext" suggests to get rid of Intltool as well. But that's beyond my scope.

@Jakko3
Copy link
Contributor Author

Jakko3 commented Feb 12, 2024

An additional remark. In the Alpine Linux build log I see the following line. That one doesn't show up in the build log here. I don't know why this is drawn in at Alpine but not here. Probably adding the "intltoolize" line doesn't help if "intltool.m4" doesn't get installed before.

  • aclocal: installing 'm4/intltool.m4' from '/usr/share/aclocal/intltool.m4'

Another line that is in the Alpine Linux build log but not in the build log here:

  • aclocal: installing 'm4/nls.m4' from '/usr/share/aclocal/nls.m4'

@leigh123linux
Copy link
Contributor

@Jakko3 you missed a dep, see #233

@Jakko3
Copy link
Contributor Author

Jakko3 commented Feb 13, 2024

Ok, thanks a lot for setting up a fix!

@regs01
Copy link

regs01 commented Nov 30, 2024

@Jakko3 you missed a dep, see #233

i'm trying to compile and see very same error

./configure: line 4913: syntax error near unexpected token `0.35.0'
./configure: line 4913: `IT_PROG_INTLTOOL(0.35.0)'

I have intltool-debian 0.35.0 package installed. Does it need something else?

edit:
Also installed just intltool and it's passing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants