Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move everything out of the container filesystem #97

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Conversation

thespad
Copy link
Member

@thespad thespad commented Nov 24, 2024

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Closes #93

Also does other stuff

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

@thespad thespad requested a review from a team November 24, 2024 19:28
@thespad thespad self-assigned this Nov 24, 2024
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/openssh-server/9.7_p1-r4-pkg-9ceb4421-dev-69cf34d58819e30916d46d233e746c1a860a7024-pr-97/index.html
https://ci-tests.linuxserver.io/lspipepr/openssh-server/9.7_p1-r4-pkg-9ceb4421-dev-69cf34d58819e30916d46d233e746c1a860a7024-pr-97/shellcheck-result.xml

Tag Passed
amd64-9.7_p1-r4-pkg-9ceb4421-dev-69cf34d58819e30916d46d233e746c1a860a7024-pr-97
arm64v8-9.7_p1-r4-pkg-9ceb4421-dev-69cf34d58819e30916d46d233e746c1a860a7024-pr-97

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/openssh-server/9.7_p1-r4-pkg-9ceb4421-dev-938056725853b90d10875f48bffd0e008b8aa36d-pr-97/index.html
https://ci-tests.linuxserver.io/lspipepr/openssh-server/9.7_p1-r4-pkg-9ceb4421-dev-938056725853b90d10875f48bffd0e008b8aa36d-pr-97/shellcheck-result.xml

Tag Passed
amd64-9.7_p1-r4-pkg-9ceb4421-dev-938056725853b90d10875f48bffd0e008b8aa36d-pr-97
arm64v8-9.7_p1-r4-pkg-9ceb4421-dev-938056725853b90d10875f48bffd0e008b8aa36d-pr-97

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/openssh-server/9.7_p1-r4-pkg-9ceb4421-dev-348399e4bad64b6a6706e6af5d36d11ab37e1ee7-pr-97/index.html
https://ci-tests.linuxserver.io/lspipepr/openssh-server/9.7_p1-r4-pkg-9ceb4421-dev-348399e4bad64b6a6706e6af5d36d11ab37e1ee7-pr-97/shellcheck-result.xml

Tag Passed
amd64-9.7_p1-r4-pkg-9ceb4421-dev-348399e4bad64b6a6706e6af5d36d11ab37e1ee7-pr-97
arm64v8-9.7_p1-r4-pkg-9ceb4421-dev-348399e4bad64b6a6706e6af5d36d11ab37e1ee7-pr-97

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/openssh-server/9.7_p1-r4-pkg-9ceb4421-dev-1383ead42c07879fadaa4667fc8e8dd670a0c2c8-pr-97/index.html
https://ci-tests.linuxserver.io/lspipepr/openssh-server/9.7_p1-r4-pkg-9ceb4421-dev-1383ead42c07879fadaa4667fc8e8dd670a0c2c8-pr-97/shellcheck-result.xml

Tag Passed
amd64-9.7_p1-r4-pkg-9ceb4421-dev-1383ead42c07879fadaa4667fc8e8dd670a0c2c8-pr-97
arm64v8-9.7_p1-r4-pkg-9ceb4421-dev-1383ead42c07879fadaa4667fc8e8dd670a0c2c8-pr-97

@thespad thespad merged commit 42e3093 into master Nov 26, 2024
5 checks passed
@thespad thespad deleted the mild-despair branch November 26, 2024 21:01
@huyz
Copy link

huyz commented Nov 27, 2024

Hmm, you sure this works?

OpenSSH is now down for me:

2024-11-27 09:20:29 *** USER_NAME cannot be set to an user that already exists in /etc/passwd. Halting init. ***
2024-11-27 00:32:07 chmod: cannot access '/config/sshd/sshd_config/ssh_host_*_key': Not a directory
2024-11-27 00:32:07 chmod: cannot access '/config/sshd/sshd_config/ssh_host_*_key.pub': Not a directory

@thespad
Copy link
Member Author

thespad commented Nov 27, 2024

Hmm, you sure this works?

OpenSSH is now down for me:

2024-11-27 09:20:29 *** USER_NAME cannot be set to an user that already exists in /etc/passwd. Halting init. ***
2024-11-27 00:32:07 chmod: cannot access '/config/sshd/sshd_config/ssh_host_*_key': Not a directory
2024-11-27 00:32:07 chmod: cannot access '/config/sshd/sshd_config/ssh_host_*_key.pub': Not a directory

Please open a new issue and provide the requested details so we can take a look.

@zaubara
Copy link

zaubara commented Nov 27, 2024

Same for me, once the container is restarted once, it won't go past the check. Removing USER_NAME help starting up the daemon, but then the custom user name won't be allowed, of course.

@thespad
Copy link
Member Author

thespad commented Nov 27, 2024

Again, please open an issue and provide some meaningful information to allow us to troubleshoot this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] confusing init-adduser behavior when picking a USER_NAME which collides with system user
5 participants