-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework the core logic of provider in Rust #872
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to overhaul the bridge between Vim and Rust, making it possible to delegate all the heavy jobs onto the Rust backend and make Vim a mere UI layer as much as possible. It's mainly achieved by allowing the Rust backend to retrieve and manipulate the Vim state on demand, which also unlocks a lot of features I'm looking forward to, such as tree-sitter highlights(#532), the preview scroll(#573), and the input history(#235).
Notable changes:
icon
attribute in each provider explicitly if it's supported,Null
by default.debounce
per provider, the debounce is enabled by default.After switching to the native searcher instead of processing the output of the shell command
rg
, thegrep
andfiles
,blines
provider is significantly faster and more responsive.There are still some TODOs and optimizations that can be done, but it should work in most cases, any feedback is welcome and testers are appreciated.
Close #875