fix: selection algo filtering on max price fixed

[ad-astra-video]

What does this pull request do? Explain your changes. (required)

Fixes behavior of gateway when no max price is set. 0 maxPrice will return to being no max price filter enabled.

The addition of maxPricePerCapability included initializing a zero max price by default so the map is fully initialized. This broke the filterByMaxPrice function that checked for an unset maxPrice of nil.
Specific updates (required)

• updates filterByMaxPrice function in selection_algorithm.go to check for 0 rather than checking for nil
• added test to cover this so will fail in future if behavior of max price filtering changes
• updated TestFilter test to set a maxPrice of 0 if none set

How did you test each of these updates (required)

Added new test and ran all tests in selection_algorithm_test.go

Does this pull request close any open issues?

Checklist:

• Read the contribution guide
• make runs successfully
• All tests in ./test.sh pass X selection_algorithm_test.go pass.
• README and other documentation updated
• Pending changelog updated

[victorges]

lgtm

[victorges]

thanks for adding tests 🙏

[ad-astra-video]

I updated for suggested change. Learned something new, did not know Sign() did that!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.72602%. Comparing base (1a4c7c7) to head (ca0ac3b).

Additional details and impacted files

@@                 Coverage Diff                 @@
##              master       #3179         +/-   ##
===================================================
+ Coverage   33.72335%   33.72602%   +0.00267%     
===================================================
  Files            141         141                 
  Lines          37434       37434                 
===================================================
+ Hits           12624       12625          +1     
+ Misses         24089       24088          -1     
  Partials         721         721                 

Files with missing lines	Coverage Δ
server/selection_algorithm.go	90.58824% <100.00000%> (ø)

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a4c7c7...ca0ac3b. Read the comment docs.

Files with missing lines	Coverage Δ
server/selection_algorithm.go	90.58824% <100.00000%> (ø)

... and 1 file with indirect coverage changes