Fix ConcurrentModificationException in TestMethodController

lkishalmi · Nov 13, 2023 · 843fc08 · 843fc08
1 parent 7f6f105
commit 843fc08
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/...sf.testrunner.ui/src/org/netbeans/modules/gsf/testrunner/ui/api/TestMethodController.java b/...sf.testrunner.ui/src/org/netbeans/modules/gsf/testrunner/ui/api/TestMethodController.java
@@ -62,12 +62,10 @@ private static void setTestMethodsImpl(StyledDocument doc, List<TestMethod> meth
             doc.putProperty(TestMethodAnnotation.DOCUMENT_ANNOTATION_LINES_KEY, annotationLines);
         }
 
-        Map<TestMethod, TestMethodAnnotation> removed = new HashMap<>(annotations);
-
-        methods.forEach(tm -> removed.remove(tm));
-
         Set<TestMethod> added = new HashSet<>(methods);
+        Map<TestMethod, TestMethodAnnotation> removed = new HashMap<>(annotations);
 
+        removed.keySet().removeAll(added);
         added.removeAll(annotations.keySet());
 
         for (TestMethod method : added) {

diff --git a/...ava.testrunner.ui/src/org/netbeans/modules/java/testrunner/ui/ComputeTestMethodsImpl.java b/...ava.testrunner.ui/src/org/netbeans/modules/java/testrunner/ui/ComputeTestMethodsImpl.java
@@ -103,7 +103,8 @@ public void run(CompilationInfo info) throws Exception {
                 }
 
                 if (!cancel.get()) {
-                    WORKER.post(() -> TestMethodController.setTestMethods(doc, methods));
+                    List<TestMethod> updateMethods = new ArrayList<>(methods);
+                    WORKER.post(() -> TestMethodController.setTestMethods(doc, updateMethods));
                 }
             }
         }