Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
dcmi: update parameters to read temperature sensors
Issue: When the system has number of CPU temperature sensors more than 8, "ipmitool dcmi get_temp_reading" can not show all of sensors. Root cause: To request to read multiple sensors for each message, ipmitool has to send "Get Temperature Readings" command with the "Entity Instance" always 0 and the "Entity Instance Start" as the offset. But the current code is sending "Entity Instance" is offset and "Entity Instance Start" always is 0. It makes ipmitool only read 1 sensor each time. Besides that, the "Entity Instance Start" value starts from 1 (not 0), therefore, the initialization has to be set to 1. Solution: This commit corrects the order of parameters and the initialization of "Entity Instance Start" byte. Resolves ipmitool/ipmitool#3 Tested: 1. Update BMC software to support 24 CPU temperature sensors 2. Request to read the temperature sensors $ipmitool dcmi get_temp_reading 3. Display full 24 CPU temperature sensors. Signed-off-by: Thang Tran <thuutran@amperecomputing.com>
- Loading branch information