Generalize SOFBMode #660
Draft
Generalize SOFBMode #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xresende, is this still a thing? If it does, what is missing to be ready for review? |
|
This seems to be deprecated, considering #1108 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow remote power supply firmware updates a StandBy mode for the IOCs was resquested.
This mode is exactly the same as the SOFBMode=On mode already implemented to FBP PSs.
The idea here is to reuse this SOFBMode mechanism by generalizing it to all types of power supplies.
ps1: @anacso17 , @fernandohds564 , we can discuss this PR along the week.
ps2: Changes from PR #659 were already committed into this PR, since they deal with 'SOFMode' names, and would be affected by renaming. Please ignore these changes for the purpose of mode renaming...