Add --reuse-sock flag so browser IDEs can reuse another SSH connections SSH_AUTH_SOCK #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkneis
force-pushed
the
feature/fix-auth-agent-sock
branch
from
786be1f to
9695082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the hidden flag
--reuse-sockto the SSH and helper ssh-server commands so that browser IDE's can first set up a SSH connection and allow the browser tunnel to reuse this.Fixes #1307, #1456 and #1464
Why do we need this? "normal" IDE's like vscode use an SSH connection to connect to the remote, this connection requersts agent forwarding so the user's SSH_AUTH_SOCK is available in the workspace.
For browser IDEs this SSH connection is not made, the only long lived connection we have is used for the credential server and runs as root, which it must.
Therefore this fix is to emulate the behaviour of the normal IDE and allow the vscode session to highjack the SSH_AUTH_SOCK of the unused "backhaul" connection.
This PR was tested using local docker provider and kubernetes with openvscode and vscode. I tried pro with vscode and it works but using openvscode does not because the devpod CLI on the platform does not have the build changes.
Additionally we perform the clean up of the tmp dir if used