Check if URL contains basic auth in URL #1523
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1515 by checking if the URL contains basic auth (detected from the presence of : in the first part of the URL). The URL is then parsed again in case both basic auth AND a branch were specified.
If there is a fancier way of doing this with regex let me know :)
My test below shows the original problem with the URL parsed, then building my changes and testing the same URL and again with a branch (note the lines with URL: and Branch:)