Fix coredns #2369
Merged
Fix coredns #2369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
FabianKramm
reviewed
Jan 2, 2025
FabianKramm
reviewed
Jan 2, 2025
rmweir
force-pushed
the
fix-coredns
branch
2 times, most recently
from
f559fae to
66cc5b5
Compare
FabianKramm
previously approved these changes
Jan 2, 2025
Prior, if the coredns deployment was using the old label, "kube-dns", it would not be updated during the coredns manifests apply. This was because label selectors are immutable. Now, if the label is outdated on the deployment, the deployment is deleted prior to the coredns manifests apply.
FabianKramm
approved these changes
Jan 2, 2025
loft-bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
Prior, if the coredns deployment was using the old label, "kube-dns", it would not be updated during the coredns manifests apply. This was because label selectors are immutable. Now, if the label is outdated on the deployment, the deployment is deleted prior to the coredns manifests apply. (cherry picked from commit 595cf00)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
FabianKramm
pushed a commit
that referenced
this pull request
Jan 2, 2025
Prior, if the coredns deployment was using the old label, "kube-dns", it would not be updated during the coredns manifests apply. This was because label selectors are immutable. Now, if the label is outdated on the deployment, the deployment is deleted prior to the coredns manifests apply. (cherry picked from commit 595cf00) Co-authored-by: Ricardo Weir <ricardo.weir@loft.sh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior, if the coredns deployment was using the old label, "kube-dns",
it would not be updated during the coredns manifests apply. This was
because label selectors are immutable. Now, if the label is outdated
on the deployment, the deployment is deleted prior to the coredns
manifests apply.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)Part of ENG-5232
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster dns would stop working on upgrade.
What else do we need to know?