Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for getter/setter descriptors #76

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

osi-oswald
Copy link

One more try :-)

Currently only descriptors with writable/value pairs are supported. This PR will add support for descriptors with getter/setter pairs.

Since these descriptor were never supported, this change will not add any regression and only add missing functionality.

I hope this upgrade makes it into the repo. All the best :-)

@osi-oswald
Copy link
Author

Btw this also solves my previous issue #74, just in a different way.

Since descriptor.initializer.call(context) is called in any case, it can be used as a "hook into the initialization". Problem solved!

@osi-oswald
Copy link
Author

Await, will add some tests

@loganfsmyth
Copy link
Owner

I still don't feel willing to make changes here. There are updates to decorators coming in the future for Babel 7, and I don't generally view this plugin as something we'll maintain once that happens. This plugin essentially existed to bridge the gap during Babel 6's lifetime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants