Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] logzio-k8s-telemetry align to new global structure #576

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

8naama
Copy link
Contributor

@8naama 8naama commented Jan 23, 2025

Description

  • Change Logz.io secret values to global to prevent duplicate values in the parent chart
    • secrets.MetricsToken >> global.logzioMetricsToken
    • secrets.TracesToken >> global.logzioTracesToken
    • secrets.SpmToken >> global.logzioSpmToken
    • secrets.k8sObjectsLogsToken >> global.logzioLogsToken
    • secrets.env_id >> global.env_id
    • secrets.LogzioRegion >> global.logzioRegion
    • secrets.CustomTracingEndpoint >> global.customTracesEndpoint
    • Deprecate secrets.p8s_logzio_name and secrets.ListenerHost
      • Add support for global.customMetricsEndpoint to substitute the custom endpoint ability that was supported with secrets.ListenerHost
  • Update readme
  • Align tests

Note: in contrast to the changes in other charts, I didn't make the below changes due to logzio-k8s-telemetry being replaced with logzio-metrics-collector in the near future:

  1. Move changelog from README.md to CHANGELOG.md
  2. Rename K8s secret resource configuration secrets >> secret

What type of PR is this?

(check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build / CI
  • ⏩ Revert

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help from somebody

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant